Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 2449173002: DevTools: fix jsdoc validator to recognize `this' usage within arrow functions (Closed)
Patch Set: review comments + moar tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /tests/document.js:1: ERROR - Access to "document" property of global object is disallowed 1 /tests/document.js:1: ERROR - Access to "document" property of global object is disallowed
2 document.bar(); 2 document.bar();
3 ^ 3 ^
4 4
5 /tests/document.js:2: ERROR - Access to "document" property of global object is disallowed 5 /tests/document.js:2: ERROR - Access to "document" property of global object is disallowed
6 window.document.bar(); 6 window.document.bar();
7 ^ 7 ^
8 8
9 /tests/document.js:5: ERROR - Access to "document" property of global object is disallowed 9 /tests/document.js:5: ERROR - Access to "document" property of global object is disallowed
10 document(); 10 document();
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 ^ 255 ^
256 256
257 /tests/proto.js:62: ERROR - Type DerivedNoSuperCall extends Base but does not pr operly invoke its constructor 257 /tests/proto.js:62: ERROR - Type DerivedNoSuperCall extends Base but does not pr operly invoke its constructor
258 DerivedNoSuperCall = function() { 258 DerivedNoSuperCall = function() {
259 ^ 259 ^
260 260
261 /tests/proto.js:73: ERROR - Type DerivedBadSuperCall extends Base but does not p roperly invoke its constructor 261 /tests/proto.js:73: ERROR - Type DerivedBadSuperCall extends Base but does not p roperly invoke its constructor
262 DerivedBadSuperCall = function() { 262 DerivedBadSuperCall = function() {
263 ^ 263 ^
264 264
265 /tests/proto.js:121: ERROR - No __proto__ assigned for type BadSetSubclass havin g @extends 265 /tests/proto.js:107: ERROR - No __proto__ assigned for type GoodSetSubclass = fu nction()
266 {
267 Set.call(this);
268 } having @extends
266 * @extends {Set.<T>} 269 * @extends {Set.<T>}
267 ^ 270 ^
268 271
269 /tests/proto.js:124: ERROR - Type BadSetSubclass extends Set but does not proper ly invoke its constructor 272 /tests/proto.js:121: ERROR - No __proto__ assigned for type BadSetSubclass = fun ction()
273 {
274 } having @extends
275 * @extends {Set.<T>}
276 ^
277
278 /tests/proto.js:124: ERROR - Type BadSetSubclass = function()
279 {
280 } extends Set but does not properly invoke its constructor
270 var BadSetSubclass = function() 281 var BadSetSubclass = function()
271 ^ 282 ^
272 283
273 /tests/proto.js:135: ERROR - No __proto__ assigned for type NS.BadSubClass havin g @extends 284 /tests/proto.js:135: ERROR - No __proto__ assigned for type NS.BadSubClass havin g @extends
274 * @extends {Base} 285 * @extends {Base}
275 ^ 286 ^
276 287
277 /tests/proto.js:137: ERROR - Type NS.BadSubClass extends Base but does not prope rly invoke its constructor 288 /tests/proto.js:137: ERROR - Type NS.BadSubClass extends Base but does not prope rly invoke its constructor
278 NS.BadSubClass = function() {} 289 NS.BadSubClass = function() {}
279 ^ 290 ^
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 ^ 410 ^
400 411
401 /tests/this.js:268: ERROR - @this annotation is required for functions referenci ng 'this' 412 /tests/this.js:268: ERROR - @this annotation is required for functions referenci ng 'this'
402 function callbackReferencingThisNotAnnotated() 413 function callbackReferencingThisNotAnnotated()
403 ^ 414 ^
404 415
405 /tests/this.js:277: ERROR - @this annotation found for function not referencing 'this' 416 /tests/this.js:277: ERROR - @this annotation found for function not referencing 'this'
406 function callbackNotReferencingThisAnnotated() 417 function callbackNotReferencingThisAnnotated()
407 ^ 418 ^
408 419
409 Total errors: 102 420 /tests/this.js:321: ERROR - @this annotation is required for functions referenci ng 'this'
421 function testArrowFunctionReferencingThisMissingAnnotation(a)
422 ^
423
424 Total errors: 104
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698