Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 2449173002: DevTools: fix jsdoc validator to recognize `this' usage within arrow functions (Closed)
Patch Set: review comments + moar tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/golden.dat
diff --git a/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/golden.dat b/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/golden.dat
index b822ae01633ed7ba1cb2c698c53cc844a8a686ce..8c72773b5f67fe5d941eddeca206ac4a60178e77 100644
--- a/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/golden.dat
+++ b/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/golden.dat
@@ -262,11 +262,22 @@ DerivedNoSuperCall = function() {
DerivedBadSuperCall = function() {
^
-/tests/proto.js:121: ERROR - No __proto__ assigned for type BadSetSubclass having @extends
+/tests/proto.js:107: ERROR - No __proto__ assigned for type GoodSetSubclass = function()
+{
+ Set.call(this);
+} having @extends
* @extends {Set.<T>}
^
-/tests/proto.js:124: ERROR - Type BadSetSubclass extends Set but does not properly invoke its constructor
+/tests/proto.js:121: ERROR - No __proto__ assigned for type BadSetSubclass = function()
+{
+} having @extends
+ * @extends {Set.<T>}
+ ^
+
+/tests/proto.js:124: ERROR - Type BadSetSubclass = function()
+{
+} extends Set but does not properly invoke its constructor
var BadSetSubclass = function()
^
@@ -406,4 +417,8 @@ NS.BadSubClass = function() {}
function callbackNotReferencingThisAnnotated()
^
-Total errors: 102
+/tests/this.js:321: ERROR - @this annotation is required for functions referencing 'this'
+ function testArrowFunctionReferencingThisMissingAnnotation(a)
+ ^
+
+Total errors: 104

Powered by Google App Engine
This is Rietveld 408576698