Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2447533002: ui: Add ref-counting to GLFence class.

Created:
4 years, 2 months ago by reveman
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Add ref-counting to GLFence class. This is needed for operations that take a fence ID as argument to be able to defer signaling of fence. BUG=653908 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -41 lines) Patch
M gpu/command_buffer/service/fence_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/fence_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_sync.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/gpu_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gl/gl_fence.h View 2 chunks +8 lines, -3 lines 0 comments Download
M ui/gl/gl_fence.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ui/gl/gl_fence_apple.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_fence_arb.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_fence_egl.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_fence_libsync.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_fence_nv.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_fence_shared_event.h View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 1 (1 generated)
reveman
4 years, 2 months ago (2016-10-23 23:07:49 UTC) #1 
Description was changed from

==========
ui: Add ref-counting to GLFence class.

This is needed for operations that take a fence ID as argument to
be able to defer signaling of fence.

BUG=653908
TEST=manual
==========

to

==========
ui: Add ref-counting to GLFence class.

This is needed for operations that take a fence ID as argument to
be able to defer signaling of fence.

BUG=653908
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Powered by Google App Engine
This is Rietveld 408576698