Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5490ca61240062de841fbcf63e408b8bca794470
Cr-Commit-Position: refs/heads/master@{#427895}

[Zhenyao Mo, 2016-10-26 17:29:03]

Description was changed from

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
==========

to

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-26 19:46:29]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 19:47:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-26 19:48:22]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-10-26 19:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:54:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Zhenyao Mo, 2016-10-26 21:05:06]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:05:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-26 21:26:45]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:27:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-26 21:27:34]

zmo@chromium.org changed reviewers:
+ piman@chromium.org

[Zhenyao Mo, 2016-10-26 21:27:35]

piman: PTAL

[piman, 2016-10-26 21:53:23]

https://codereview.chromium.org/2447423002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2447423002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13037: DCHECK(data ||
!image_size);
Oh, I forgot one thing in the previous review - and this is true for other
Bucket versions.

I think we want to fail the *Bucket call if a pixel unpack buffer is bound,
otherwise the data pointer will be interpreted as an offset into that buffer.

[commit-bot: I haz the power, 2016-10-26 22:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:24:54]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-10-26 22:31:20]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-10-26 22:31:58]

Please take another look.

https://codereview.chromium.org/2447423002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2447423002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13037: DCHECK(data ||
!image_size);
On 2016/10/26 21:53:22, piman wrote:
> Oh, I forgot one thing in the previous review - and this is true for other
> Bucket versions.
> 
> I think we want to fail the *Bucket call if a pixel unpack buffer is bound,
> otherwise the data pointer will be interpreted as an offset into that buffer.

Good catch. Added.

[commit-bot: I haz the power, 2016-10-26 22:32:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-10-26 22:41:53]

lgtm

[Zhenyao Mo, 2016-10-26 23:46:47]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2016-10-26 23:47:02]

Description was changed from

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
NOTRY=true
TEST=gpu_unittests,webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-26 23:47:29]

On 2016/10/26 22:41:53, piman wrote:
> lgtm

The linux_chromium_rel_ng failure is unrelated. landing with NOTRY=true

[Zhenyao Mo, 2016-10-26 23:47:35]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-10-26 23:48:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-26 23:50:38]

Description was changed from

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
NOTRY=true
TEST=gpu_unittests,webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-26 23:50:46]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2016-10-26 23:51:14]

On 2016/10/26 23:48:23, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Never mind. Merge conflict.  Still landing through full CQ

[Zhenyao Mo, 2016-10-26 23:52:58]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-10-26 23:52:58]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2447423002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-26 23:53:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-27 00:52:45]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2016-10-27 00:53:09]

Description was changed from

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-27 00:53:15]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:58:12]

Description was changed from

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-27 00:58:18]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-27 00:59:53]

Description was changed from

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Handle CompressedTex{Sub}Image{2|3}D interaction with PBO.

BUG=429053
TEST=gpu_unittests,webgl2_conformance
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5490ca61240062de841fbcf63e408b8bca794470
Cr-Commit-Position: refs/heads/master@{#427895}
==========

[commit-bot: I haz the power, 2016-10-27 00:59:54]

Patchset 5 (id:??) landed as
https://crrev.com/5490ca61240062de841fbcf63e408b8bca794470
Cr-Commit-Position: refs/heads/master@{#427895}