Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2453823003: Clean up dead code in build_gles2_cmd_buffer.py (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up dead code in build_gles2_cmd_buffer.py BUG= TEST=run the py file and no code change NOTRY=true R=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/f0d5c7f6ad6a5130ec57d076a1939cfdc9a74621 Cr-Commit-Position: refs/heads/master@{#427897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +1 line, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Zhenyao Mo
piman: a simple clean up CL
4 years, 1 month ago (2016-10-26 23:59:05 UTC) #2
piman
lgtm
4 years, 1 month ago (2016-10-27 00:33:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453823003/1
4 years, 1 month ago (2016-10-27 00:59:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 01:04:53 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 01:07:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0d5c7f6ad6a5130ec57d076a1939cfdc9a74621
Cr-Commit-Position: refs/heads/master@{#427897}

Powered by Google App Engine
This is Rietveld 408576698