chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc - Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: A self check encountered a few things.. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('K') | « chrome/browser/ui/views/location_bar/zoom_bubble_view.cc ('k') | chrome/browser/ui/views/validation_message_bubble_delegate.cc » ('j') | ui/views/bubble/bubble_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

index ef4ee235b72bac88e71673901598052de54ba791..d3fa8e8e5d0e24de97a7fb46e6d4234cb28f816f 100644

--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

@@ -46,7 +46,7 @@ IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, MAYBE_NonImmersiveFullscreen) {

ZoomBubbleView::ShowBubble(web_contents, true);

ASSERT_TRUE(ZoomBubbleView::IsShowing());

const ZoomBubbleView* zoom_bubble = ZoomBubbleView::GetZoomBubbleForTest();

- EXPECT_TRUE(zoom_bubble->anchor_view());

+ EXPECT_TRUE(zoom_bubble->AnchorView());

// Entering fullscreen should close the bubble. (We enter into tab fullscreen

// here because tab fullscreen is non-immersive even when

@@ -69,7 +69,7 @@ IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, MAYBE_NonImmersiveFullscreen) {

ZoomBubbleView::ShowBubble(web_contents, true);

ASSERT_TRUE(ZoomBubbleView::IsShowing());

zoom_bubble = ZoomBubbleView::GetZoomBubbleForTest();

- EXPECT_FALSE(zoom_bubble->anchor_view());

+ EXPECT_FALSE(zoom_bubble->AnchorView());

// Exit fullscreen before ending the test for the sake of sanity.

{

@@ -112,7 +112,7 @@ IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, ImmersiveFullscreen) {

ZoomBubbleView::ShowBubble(web_contents, true);

ASSERT_TRUE(ZoomBubbleView::IsShowing());

const ZoomBubbleView* zoom_bubble = ZoomBubbleView::GetZoomBubbleForTest();

- EXPECT_FALSE(zoom_bubble->anchor_view());

+ EXPECT_FALSE(zoom_bubble->AnchorView());

// An immersive reveal should hide the zoom bubble.

scoped_ptr<ImmersiveRevealedLock> immersive_reveal_lock(

@@ -126,7 +126,7 @@ IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, ImmersiveFullscreen) {

ZoomBubbleView::ShowBubble(web_contents, true);

ASSERT_TRUE(ZoomBubbleView::IsShowing());

zoom_bubble = ZoomBubbleView::GetZoomBubbleForTest();

- EXPECT_TRUE(zoom_bubble->anchor_view());

+ EXPECT_TRUE(zoom_bubble->AnchorView());

// The top-of-window views should not hide till the zoom bubble hides. (It

// would be weird if the view to which the zoom bubble is anchored hid while