chrome/browser/ui/views/validation_message_bubble_delegate.cc - Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/validation_message_bubble_delegate.cc

Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: A self check encountered a few things.. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('K') | « chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | ui/views/bubble/bubble_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/validation_message_bubble_delegate.cc

diff --git a/chrome/browser/ui/views/validation_message_bubble_delegate.cc b/chrome/browser/ui/views/validation_message_bubble_delegate.cc

index 5b2566feb43a64b494cad138cdffeba349b21029..ac8802b036ea7f084bab7cb99a423e17f09b82b4 100644

--- a/chrome/browser/ui/views/validation_message_bubble_delegate.cc

+++ b/chrome/browser/ui/views/validation_message_bubble_delegate.cc

@@ -26,7 +26,7 @@ ValidationMessageBubbleDelegate::ValidationMessageBubbleDelegate(

: observer_(observer), width_(0), height_(0) {

set_use_focusless(true);

set_arrow(views::BubbleBorder::TOP_LEFT);

- set_anchor_rect(anchor_in_screen);

+ SetAnchorRect(anchor_in_screen);

ResourceBundle& bundle = ResourceBundle::GetSharedInstance();

views::ImageView* icon = new views::ImageView();

@@ -86,7 +86,7 @@ void ValidationMessageBubbleDelegate::Close() {

void ValidationMessageBubbleDelegate::SetPositionRelativeToAnchor(

const gfx::Rect& anchor_in_screen) {

- set_anchor_rect(anchor_in_screen);

+ SetAnchorRect(anchor_in_screen);

SizeToContents();

}