Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3388)

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view.cc

Issue 24469006: Fixing crash Report - Magic Signature: views::View::ConvertPointToScreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: A self check encountered a few things.. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
index f3d61a3f7aac0876c9b40db95cdcb74605bb8f62..d538900cb952175ceea51ab4c25adfb77c473725 100644
--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
@@ -56,7 +56,7 @@ void ZoomBubbleView::ShowBubble(content::WebContents* web_contents,
// is equal to |auto_close|, the bubble can be reused and only the label text
// needs to be updated.
if (zoom_bubble_ &&
- zoom_bubble_->anchor_view() == anchor_view &&
+ zoom_bubble_->AnchorView() == anchor_view &&
zoom_bubble_->auto_close_ == auto_close) {
zoom_bubble_->Refresh();
} else {
@@ -135,7 +135,7 @@ ZoomBubbleView::~ZoomBubbleView() {
}
void ZoomBubbleView::AdjustForFullscreen(const gfx::Rect& screen_bounds) {
- if (anchor_view())
+ if (AnchorView())
return;
// TODO(dbeam): should RTL logic be done in views::BubbleDelegateView?
@@ -143,7 +143,7 @@ void ZoomBubbleView::AdjustForFullscreen(const gfx::Rect& screen_bounds) {
const int x_pos = base::i18n::IsRTL() ?
screen_bounds.x() + bubble_half_width + kFullscreenPaddingEnd :
screen_bounds.right() - bubble_half_width - kFullscreenPaddingEnd;
- set_anchor_rect(gfx::Rect(x_pos, screen_bounds.y(), 0, 0));
+ SetAnchorRect(gfx::Rect(x_pos, screen_bounds.y(), 0, 0));
// Used to update |views::BubbleDelegate::anchor_rect_| in a semi-hacky way.
// TODO(dbeam): update only the bounds of this view or its border or frame.

Powered by Google App Engine
This is Rietveld 408576698