Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2446633002: Fix RecreateSKPs recipe to correctly fail when the upload fails (Closed)

Created:
4 years, 1 month ago by borenet2
Modified:
4 years, 1 month ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix RecreateSKPs recipe to correctly fail when the upload fails BUG=skia:5879 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2446633002 Committed: https://skia.googlesource.com/skia/+/b2cf266151a6698a6c667fb97f9c8d3cbdd8b4e6

Patch Set 1 #

Patch Set 2 : Actually fix the bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M infra/bots/recipes/swarm_RecreateSKPs.py View 1 3 chunks +42 lines, -16 lines 0 comments Download
A + infra/bots/recipes/swarm_RecreateSKPs.expected/failed_upload.json View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
borenet
Patch set 1 adds the test to demonstrate that failed upload does not cause the ...
4 years, 1 month ago (2016-10-24 15:10:59 UTC) #3
rmistry
lgtm
4 years, 1 month ago (2016-10-24 15:12:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446633002/20001
4 years, 1 month ago (2016-10-24 15:13:31 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 15:40:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b2cf266151a6698a6c667fb97f9c8d3cbdd8b4e6

Powered by Google App Engine
This is Rietveld 408576698