Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: infra/bots/recipes/swarm_RecreateSKPs.expected/failed_upload.json

Issue 2446633002: Fix RecreateSKPs recipe to correctly fail when the upload fails (Closed)
Patch Set: Actually fix the bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « infra/bots/recipes/swarm_RecreateSKPs.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipes/swarm_RecreateSKPs.expected/failed_upload.json
diff --git a/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json b/infra/bots/recipes/swarm_RecreateSKPs.expected/failed_upload.json
similarity index 98%
copy from infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json
copy to infra/bots/recipes/swarm_RecreateSKPs.expected/failed_upload.json
index 15feac8777a35537c416531312ed26a8c766d404..a198dfee12dea0af14cb288a750fe38b833cacf5 100644
--- a/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json
+++ b/infra/bots/recipes/swarm_RecreateSKPs.expected/failed_upload.json
@@ -297,7 +297,11 @@
"GOPATH": "[CUSTOM_/_B_WORK]/gopath",
"PATH": "[DEPOT_TOOLS]:%(PATH)s"
},
- "name": "Upload SKPs"
+ "name": "Upload SKPs",
+ "~followup_annotations": [
+ "step returned non-zero exit code: 1",
+ "@@@STEP_FAILURE@@@"
+ ]
},
{
"cmd": [
@@ -328,7 +332,8 @@
},
{
"name": "$result",
+ "reason": "Step('Upload SKPs') failed with return_code 1",
"recipe_result": null,
- "status_code": 0
+ "status_code": 1
}
]
« no previous file with comments | « infra/bots/recipes/swarm_RecreateSKPs.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698