Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: infra/bots/recipes/swarm_RecreateSKPs.expected/failed_upload.json

Issue 2446633002: Fix RecreateSKPs recipe to correctly fail when the upload fails (Closed)
Patch Set: Actually fix the bug Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « infra/bots/recipes/swarm_RecreateSKPs.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 [ 1 [
2 { 2 {
3 "cmd": [ 3 "cmd": [
4 "python", 4 "python",
5 "-u", 5 "-u",
6 "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os. path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n", 6 "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os. path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",
7 "[CUSTOM_/_B_WORK]", 7 "[CUSTOM_/_B_WORK]",
8 "511" 8 "511"
9 ], 9 ],
10 "name": "makedirs checkout_path", 10 "name": "makedirs checkout_path",
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 "[CUSTOM_/_B_WORK]/skia/infra/bots/upload_skps.py", 290 "[CUSTOM_/_B_WORK]/skia/infra/bots/upload_skps.py",
291 "--target_dir", 291 "--target_dir",
292 "[SLAVE_BUILD]/skp_output" 292 "[SLAVE_BUILD]/skp_output"
293 ], 293 ],
294 "cwd": "[CUSTOM_/_B_WORK]/skia", 294 "cwd": "[CUSTOM_/_B_WORK]/skia",
295 "env": { 295 "env": {
296 "CHROME_HEADLESS": "1", 296 "CHROME_HEADLESS": "1",
297 "GOPATH": "[CUSTOM_/_B_WORK]/gopath", 297 "GOPATH": "[CUSTOM_/_B_WORK]/gopath",
298 "PATH": "[DEPOT_TOOLS]:%(PATH)s" 298 "PATH": "[DEPOT_TOOLS]:%(PATH)s"
299 }, 299 },
300 "name": "Upload SKPs" 300 "name": "Upload SKPs",
301 "~followup_annotations": [
302 "step returned non-zero exit code: 1",
303 "@@@STEP_FAILURE@@@"
304 ]
301 }, 305 },
302 { 306 {
303 "cmd": [ 307 "cmd": [
304 "python", 308 "python",
305 "-u", 309 "-u",
306 "\nimport os\n\n\nTOKEN_FILE = '.depot_tools_oauth2_tokens'\nTOKEN_FILE_BA CKUP = '.depot_tools_oauth2_tokens.old'\n\n\nhome = os.path.expanduser('~')\ntok en_file = os.path.join(home, TOKEN_FILE)\nif os.path.isfile(token_file):\n os.r emove(token_file)\n\nbackup_file = os.path.join(home, TOKEN_FILE_BACKUP)\nif os. path.isfile(backup_file):\n os.rename(backup_file, token_file)\n" 310 "\nimport os\n\n\nTOKEN_FILE = '.depot_tools_oauth2_tokens'\nTOKEN_FILE_BA CKUP = '.depot_tools_oauth2_tokens.old'\n\n\nhome = os.path.expanduser('~')\ntok en_file = os.path.join(home, TOKEN_FILE)\nif os.path.isfile(token_file):\n os.r emove(token_file)\n\nbackup_file = os.path.join(home, TOKEN_FILE_BACKUP)\nif os. path.isfile(backup_file):\n os.rename(backup_file, token_file)\n"
307 ], 311 ],
308 "name": "depot-tools-auth logout", 312 "name": "depot-tools-auth logout",
309 "~followup_annotations": [ 313 "~followup_annotations": [
310 "@@@STEP_LOG_LINE@python.inline@@@@", 314 "@@@STEP_LOG_LINE@python.inline@@@@",
(...skipping 10 matching lines...) Expand all
321 "@@@STEP_LOG_LINE@python.inline@ os.remove(token_file)@@@", 325 "@@@STEP_LOG_LINE@python.inline@ os.remove(token_file)@@@",
322 "@@@STEP_LOG_LINE@python.inline@@@@", 326 "@@@STEP_LOG_LINE@python.inline@@@@",
323 "@@@STEP_LOG_LINE@python.inline@backup_file = os.path.join(home, TOKEN_FIL E_BACKUP)@@@", 327 "@@@STEP_LOG_LINE@python.inline@backup_file = os.path.join(home, TOKEN_FIL E_BACKUP)@@@",
324 "@@@STEP_LOG_LINE@python.inline@if os.path.isfile(backup_file):@@@", 328 "@@@STEP_LOG_LINE@python.inline@if os.path.isfile(backup_file):@@@",
325 "@@@STEP_LOG_LINE@python.inline@ os.rename(backup_file, token_file)@@@", 329 "@@@STEP_LOG_LINE@python.inline@ os.rename(backup_file, token_file)@@@",
326 "@@@STEP_LOG_END@python.inline@@@" 330 "@@@STEP_LOG_END@python.inline@@@"
327 ] 331 ]
328 }, 332 },
329 { 333 {
330 "name": "$result", 334 "name": "$result",
335 "reason": "Step('Upload SKPs') failed with return_code 1",
331 "recipe_result": null, 336 "recipe_result": null,
332 "status_code": 0 337 "status_code": 1
333 } 338 }
334 ] 339 ]
OLDNEW
« no previous file with comments | « infra/bots/recipes/swarm_RecreateSKPs.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698