Complete checked state announcements and clarify state usage

Complete checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if aria-checked is set to true, the state bitmap doesn't actually contain the checked state. ChromeVox should not have to make this workaround, but for the purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g. collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=646100, 628862
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6007cdb65f04ec552d34c04b744cd50f16defc01
Cr-Commit-Position: refs/heads/master@{#427491}

[David Tseng, 2016-10-25 17:10:01]

Description was changed from

==========
Fix checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if
aria-checked is set to true, the state bitmap doesn't actually contain the
checked state. ChromeVox should not have to make this workaround, but for the
purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g.
collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=
==========

to

==========
Fix checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if
aria-checked is set to true, the state bitmap doesn't actually contain the
checked state. ChromeVox should not have to make this workaround, but for the
purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g.
collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-25 17:11:19]

Description was changed from

==========
Fix checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if
aria-checked is set to true, the state bitmap doesn't actually contain the
checked state. ChromeVox should not have to make this workaround, but for the
purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g.
collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Complete checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if
aria-checked is set to true, the state bitmap doesn't actually contain the
checked state. ChromeVox should not have to make this workaround, but for the
purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g.
collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=646100,628862
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-25 17:11:19]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-10-25 17:56:23]

Patchset #2 (id:20001) has been deleted

[David Tseng, 2016-10-25 17:56:33]

Patchset #1 (id:1) has been deleted

[dmazzoni, 2016-10-25 18:46:50]

I just did a quick check and aria-checked is stored in the
state bitmap for simple examples I tried. It's also covered
by several tests on other platforms. Can you create a
failing test demonstrating what you're seeing so I
can dig into it? Maybe there are bugs in the state bitmap
for automation.

We shouldn't have to work around this.

[David Tseng, 2016-10-25 19:23:04]

On Tue, Oct 25, 2016 at 11:46 AM, <dmazzoni@chromium.org> wrote:

> I just did a quick check and aria-checked is stored in the
> state bitmap for simple examples I tried. It's also covered
> by several tests on other platforms. Can you create a
> failing test demonstrating what you're seeing so I
> can dig into it? Maybe there are bugs in the state bitmap
> for automation.
>
> We shouldn't have to work around this.
>
> I'd rather check this in now and remove the workaround later. The mixed
> case is needed anway.
>


c.htmlAttributes
Object { type: "image", src: "checked.gif", alt: "choose a state",
role: "checkbox", aria-checked: "true" }
js> c.name
"choose a state"
js> c.root.url
"http://files.paciellogroup.com/blogmisc/ARIA/tristatecheck.html"
js> JSON.stringify(c.state)
"{"focusable":true,"readOnly":true,"focused":true}"
js> c.role
"checkBox"
js>

c.htmlAttributes
Object { type: "image", src: "checked.gif", alt: "choose a state",
role: "checkbox", aria-checked: "true" }
js> c.name
"choose a state"
js> c.root.url
"http://files.paciellogroup.com/blogmisc/ARIA/tristatecheck.html"
js> JSON.stringify(c.state)
"{"focusable":true,"readOnly":true,"focused":true}"
js> c.role
"checkBox"

js>

> https://codereview.chromium.org/2446293002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-10-25 19:25:27]

lgtm

OK, I'll revert part of it when I fix it

[David Tseng, 2016-10-25 19:25:58]

Also, checked on Mac, it fails there as well.

On Tue, Oct 25, 2016 at 12:23 PM, David Tseng <dtseng@chromium.org> wrote:

>
>
> On Tue, Oct 25, 2016 at 11:46 AM, <dmazzoni@chromium.org> wrote:
>
>> I just did a quick check and aria-checked is stored in the
>> state bitmap for simple examples I tried. It's also covered
>> by several tests on other platforms. Can you create a
>> failing test demonstrating what you're seeing so I
>> can dig into it? Maybe there are bugs in the state bitmap
>> for automation.
>>
>> We shouldn't have to work around this.
>>
>> I'd rather check this in now and remove the workaround later. The mixed
>> case is needed anway.
>>
>
>
> c.htmlAttributes
> Object { type: "image", src: "checked.gif", alt: "choose a state", role:
"checkbox", aria-checked: "true" }
> js> c.name
> "choose a state"
> js> c.root.url
> "http://files.paciellogroup.com/blogmisc/ARIA/tristatecheck.html"
> js> JSON.stringify(c.state)
> "{"focusable":true,"readOnly":true,"focused":true}"
> js> c.role
> "checkBox"
> js>
>
> c.htmlAttributes
> Object { type: "image", src: "checked.gif", alt: "choose a state", role:
"checkbox", aria-checked: "true" }
> js> c.name
> "choose a state"
> js> c.root.url
> "http://files.paciellogroup.com/blogmisc/ARIA/tristatecheck.html"
> js> JSON.stringify(c.state)
> "{"focusable":true,"readOnly":true,"focused":true}"
> js> c.role
> "checkBox"
>
> js>
>
>> https://codereview.chromium.org/2446293002/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Chromium-reviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to chromium-reviews+unsubscribe@chromium.org.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2016-10-25 20:49:47]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-25 20:49:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2446293002/#ps60001
(title: "Rebase tests.")

[commit-bot: I haz the power, 2016-10-25 20:50:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 21:45:50]

Description was changed from

==========
Complete checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if
aria-checked is set to true, the state bitmap doesn't actually contain the
checked state. ChromeVox should not have to make this workaround, but for the
purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g.
collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=646100,628862
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Complete checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if
aria-checked is set to true, the state bitmap doesn't actually contain the
checked state. ChromeVox should not have to make this workaround, but for the
purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g.
collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=646100,628862
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-25 21:45:51]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-25 21:47:05]

Description was changed from

==========
Complete checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if
aria-checked is set to true, the state bitmap doesn't actually contain the
checked state. ChromeVox should not have to make this workaround, but for the
purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g.
collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=646100,628862
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Complete checked state announcements and clarify state usage

Firstly, the checked state has some unexpected bheaviors as follows:
- aria checked is not reflected by the state bitmap; for example, if
aria-checked is set to true, the state bitmap doesn't actually contain the
checked state. ChromeVox should not have to make this workaround, but for the
purposes of output, we should do the right thing regardless of this behavior
- some states really should only be relevant  when they are true (e.g.
collapsed, expanded, visited); encode this in the state data
- other states are only relevant for specific roles (e.g. pressed).

BUG=646100,628862
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6007cdb65f04ec552d34c04b744cd50f16defc01
Cr-Commit-Position: refs/heads/master@{#427491}
==========

[commit-bot: I haz the power, 2016-10-25 21:47:07]

Patchset 2 (id:??) landed as
https://crrev.com/6007cdb65f04ec552d34c04b744cd50f16defc01
Cr-Commit-Position: refs/heads/master@{#427491}