Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3227)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

Issue 2446293002: Complete checked state announcements and clarify state usage (Closed)
Patch Set: Rebase tests. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
index 0431f4f22b336aeef64ff17326d720090485bcb2..bcb151d1fb64a6cf858eccda24c9e6b1f5cf0322 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
@@ -132,11 +132,10 @@ TEST_F('OutputE2ETest', 'Checkbox', function() {
var el = root.firstChild.firstChild;
var range = cursors.Range.fromNode(el);
var o = new Output().withSpeechAndBraille(range, null, 'navigate');
- checkSpeechOutput('|Check box|not checked',
+ checkSpeechOutput('|Check box|Not checked',
[
{value: new Output.EarconAction('CHECK_OFF'), start: 0, end: 0},
- {value: 'role', start: 1, end: 10},
- {value: 'state', start: 11, end: 22}
+ {value: 'role', start: 1, end: 10}
],
o);
checkBrailleOutput(
@@ -504,6 +503,10 @@ SYNC_TEST_F('OutputE2ETest', 'MessageIdAndEarconValidity', function() {
var value = Output.STATE_INFO_[key];
for (innerKey in value) {
var innerValue = value[innerKey];
+ if (typeof(innerValue) == 'boolean') {
+ assertEquals('isRoleSpecific', innerKey);
+ continue;
+ }
Msgs.getMsg(innerValue.msgId);
Msgs.getMsg(innerValue.msgId + '_brl');
assertFalse(/[A-Z]+/.test(innerValue.msgId));
@@ -618,7 +621,8 @@ TEST_F('OutputE2ETest', 'ToggleButton', function() {
assertEqualsJSON({string_: '|Subscribe|Button|Pressed', spans_: [
{value: {earconId: 'CHECK_ON'}, start: 0, end: 0},
{value: 'name', start: 1, end:10},
- {value: 'role', start: 11, end: 17}
+ {value: 'role', start: 11, end: 17},
+ {value: 'state', start: 18, end: 25}
]}, o.speechOutputForTest);
});
});

Powered by Google App Engine
This is Rietveld 408576698