Complete checked state announcements and clarify state usage

chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 GEN_INCLUDE(['../../testing/assert_additions.js']);
 GEN_INCLUDE(['../../testing/chromevox_next_e2e_test_base.js']);
 
 /**
  * Gets the braille output and asserts that it matches expected values.
  * Annotations in the output that are primitive strings are ignored.
@@ skipping 114 matching lines @@
           o);
   });
 });
 
 TEST_F('OutputE2ETest', 'Checkbox', function() {
   this.runWithLoadedTree('<input type="checkbox">',
     function(root) {
       var el = root.firstChild.firstChild;
       var range = cursors.Range.fromNode(el);
       var o = new Output().withSpeechAndBraille(range, null, 'navigate');
-      checkSpeechOutput('|Check box|not checked',
+      checkSpeechOutput('|Check box|Not checked',
           [
             {value: new Output.EarconAction('CHECK_OFF'), start: 0, end: 0},
-            {value: 'role', start: 1, end: 10},
-            {value: 'state', start: 11, end: 22}
+            {value: 'role', start: 1, end: 10}
           ],
           o);
       checkBrailleOutput(
           'chk ( )',
           [{value: new Output.NodeSpan(el), start: 0, end: 7}],
           o);
   });
 });
 
 TEST_F('OutputE2ETest', 'InLineTextBoxValueGetsIgnored', function() {
@@ skipping 347 matching lines @@
       Msgs.getMsg(value.msgId + '_brl');
       assertFalse(/[A-Z]+/.test(value.msgId));
     }
     if (value.earconId)
       assertNotNullNorUndefined(cvox.Earcon[value.earconId]);
   }
   for (var key in Output.STATE_INFO_) {
     var value = Output.STATE_INFO_[key];
     for (innerKey in value) {
       var innerValue = value[innerKey];
+      if (typeof(innerValue) == 'boolean') {
+        assertEquals('isRoleSpecific', innerKey);
+        continue;
+      }
       Msgs.getMsg(innerValue.msgId);
       Msgs.getMsg(innerValue.msgId + '_brl');
       assertFalse(/[A-Z]+/.test(innerValue.msgId));
       if (innerValue.earconId)
         assertNotNullNorUndefined(cvox.Earcon[innerValue.earconId]);
     }
   }
   for (var key in Output.INPUT_TYPE_MESSAGE_IDS_) {
     var msgId = Output.INPUT_TYPE_MESSAGE_IDS_[key];
     assertFalse(/[A-Z]+/.test(msgId));
@@ skipping 94 matching lines @@
 });
 TEST_F('OutputE2ETest', 'ToggleButton', function() {
   this.runWithLoadedTree(function() {/*!
       <div role="button" aria-pressed="true">Subscribe</div>*/},
     function(root) {
       var el = root.firstChild;
       var o = new Output().withSpeech(cursors.Range.fromNode(el));
       assertEqualsJSON({string_: '|Subscribe|Button|Pressed', spans_: [
         {value: {earconId: 'CHECK_ON'}, start: 0, end: 0},
         {value: 'name', start: 1, end:10},
-        {value: 'role', start: 11, end: 17}
+        {value: 'role', start: 11, end: 17},
+        {value: 'state', start: 18, end: 25}
       ]}, o.speechOutputForTest);
   });
 });
 
 TEST_F('OutputE2ETest', 'JoinDescendants', function() {
   this.runWithLoadedTree(function() {/*!
       <p>This</p>
       <p>fragment</p>
       <p>Should be separated</p>
       <p>with spaces</p>
@@ skipping 25 matching lines @@
       <div role="row" tabindex=0 aria-label="start"></div>
       <div role="row" tabindex=0 aria-label="end"></div>
     */},
     function(root) {
       var r1 = cursors.Range.fromNode(root.firstChild);
       var r2 = cursors.Range.fromNode(root.lastChild);
       assertEquals('start|Row',
           new Output().withSpeech(r1, r2).speechOutputForTest.string_);
   });
 });