Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2445923002: [Devtools] Cleanup DataGrid.js (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Cleanup DataGrid.js This patch simply cleansup some DataGrid a little. R=dgozman,lushnikov BUG=None Committed: https://crrev.com/5fe0de886bab8bafaf31dafe877c8afa01d64f12 Cr-Commit-Position: refs/heads/master@{#427255}

Patch Set 1 : changes #

Total comments: 2

Patch Set 2 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -76 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js View 1 9 chunks +49 lines, -75 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
allada
PTL
4 years, 1 month ago (2016-10-24 21:32:28 UTC) #1
lushnikov
https://codereview.chromium.org/2445923002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js (right): https://codereview.chromium.org/2445923002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js#newcode246 third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js:246: var tBody = this._dataTableBody; this is a file-private field; ...
4 years, 1 month ago (2016-10-24 23:34:56 UTC) #3
allada
PTaL https://codereview.chromium.org/2445923002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js (right): https://codereview.chromium.org/2445923002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js#newcode246 third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js:246: var tBody = this._dataTableBody; On 2016/10/24 23:34:55, lushnikov ...
4 years, 1 month ago (2016-10-24 23:49:11 UTC) #4
lushnikov
lgtm
4 years, 1 month ago (2016-10-24 23:54:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445923002/40001
4 years, 1 month ago (2016-10-25 01:59:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-25 02:51:49 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 02:56:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fe0de886bab8bafaf31dafe877c8afa01d64f12
Cr-Commit-Position: refs/heads/master@{#427255}

Powered by Google App Engine
This is Rietveld 408576698