command buffer: remove "unsafe" from autogenerated ES3 apis; cleanly separate ES3 tests

command buffer: remove "unsafe" from autogenerated ES3 apis; cleanly separate ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/98447294ad99e7e5a1a83a1ee88d4b9086af9837
Cr-Commit-Position: refs/heads/master@{#427868}

[Kai Ninomiya, 2016-10-26 19:22:38]

Description was changed from

==========
remove "unsafe" from autogenerated ES3 apis; cleanly separate ES3 tests

BUG=654787
==========

to

==========
remove "unsafe" from autogenerated ES3 apis; cleanly separate ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-10-26 19:22:57]

Description was changed from

==========
remove "unsafe" from autogenerated ES3 apis; cleanly separate ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
remove "unsafe" from autogenerated ES3 apis; cleanly separate ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-10-26 19:23:07]

Description was changed from

==========
remove "unsafe" from autogenerated ES3 apis; cleanly separate ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: remove "unsafe" from autogenerated ES3 apis; cleanly separate
ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-10-26 19:31:48]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[Kai Ninomiya, 2016-10-26 19:32:23]

kainino@chromium.org changed reviewers:
+ zmo@chromium.org

[Kai Ninomiya, 2016-10-26 19:32:24]

zmo, PTAL

[commit-bot: I haz the power, 2016-10-26 19:33:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:43:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kai Ninomiya, 2016-10-26 21:25:55]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:26:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-26 22:01:50]

lgtm

https://codereview.chromium.org/2445323006/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest.h (right):

https://codereview.chromium.org/2445323006/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest.h:105: // Override default
setup so ES3 capabilities are enabled by default.
This comment is wrong because you did nothing in the SetUp()

[Kai Ninomiya, 2016-10-26 22:10:17]

Thanks

https://codereview.chromium.org/2445323006/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest.h (right):

https://codereview.chromium.org/2445323006/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest.h:105: // Override default
setup so ES3 capabilities are enabled by default.
On 2016/10/26 22:01:50, Zhenyao Mo wrote:
> This comment is wrong because you did nothing in the SetUp()

Done.

[Kai Ninomiya, 2016-10-26 22:11:04]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-10-26 22:11:05]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2445323006/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2016-10-26 22:11:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 23:16:57]

Description was changed from

==========
command buffer: remove "unsafe" from autogenerated ES3 apis; cleanly separate
ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: remove "unsafe" from autogenerated ES3 apis; cleanly separate
ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-26 23:16:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 23:22:02]

Description was changed from

==========
command buffer: remove "unsafe" from autogenerated ES3 apis; cleanly separate
ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: remove "unsafe" from autogenerated ES3 apis; cleanly separate
ES3 tests

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/98447294ad99e7e5a1a83a1ee88d4b9086af9837
Cr-Commit-Position: refs/heads/master@{#427868}
==========

[commit-bot: I haz the power, 2016-10-26 23:22:05]

Patchset 3 (id:??) landed as
https://crrev.com/98447294ad99e7e5a1a83a1ee88d4b9086af9837
Cr-Commit-Position: refs/heads/master@{#427868}