command buffer: remove "unsafe" from autogenerated ES3 apis; cleanly separate ES3 tests

gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <stdint.h>
 
+#include "base/command_line.h"
 #include "gpu/command_buffer/common/gles2_cmd_format.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
 #include "gpu/command_buffer/service/cmd_buffer_engine.h"
 #include "gpu/command_buffer/service/context_group.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h"
 #include "gpu/command_buffer/service/program_manager.h"
 #include "gpu/command_buffer/service/test_helper.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gl/gl_mock.h"
 
@@ skipping 17 matching lines @@
 }
 }  // namespace
 
 class GLES2DecoderTest2 : public GLES2DecoderTestBase {
  public:
   GLES2DecoderTest2() { }
 
   void TestAcceptedUniform(GLenum uniform_type,
                            uint32_t accepts_apis,
                            bool es3_enabled) {
-    decoder_->set_unsafe_es3_apis_enabled(es3_enabled);
-
     SetupShaderForUniform(uniform_type);
     bool valid_uniform = false;
 
     EXPECT_CALL(*gl_, Uniform1i(1, _)).Times(AnyNumber());
     EXPECT_CALL(*gl_, Uniform1iv(1, _, _)).Times(AnyNumber());
     EXPECT_CALL(*gl_, Uniform2iv(1, _, _)).Times(AnyNumber());
     EXPECT_CALL(*gl_, Uniform3iv(1, _, _)).Times(AnyNumber());
     EXPECT_CALL(*gl_, Uniform4iv(1, _, _)).Times(AnyNumber());
     EXPECT_CALL(*gl_, Uniform1f(1, _)).Times(AnyNumber());
     EXPECT_CALL(*gl_, Uniform1fv(1, _, _)).Times(AnyNumber());
@@ skipping 503 matching lines @@
 
         cmd.Init(1, 2, true, &data[0][0]);
         EXPECT_EQ(error::kNoError, ExecuteImmediateCmd(cmd, sizeof(data)));
         EXPECT_EQ(valid_uniform ? GL_NO_ERROR : GL_INVALID_OPERATION,
                   GetGLError());
       }
     }
   }
 };
 
+class GLES3DecoderTest2 : public GLES2DecoderTest2 {
+ public:
+  GLES3DecoderTest2() { shader_language_version_ = 300; }
+ protected:
+  void SetUp() override {
+    base::CommandLine command_line(0, nullptr);
+    command_line.AppendSwitch(switches::kEnableUnsafeES3APIs);
+    InitState init;
+    init.gl_version = "OpenGL ES 3.0";
+    init.bind_generates_resource = true;
+    init.context_type = CONTEXT_TYPE_OPENGLES3;
+    InitDecoderWithCommandLine(init, &command_line);
+  }
+};
+
 INSTANTIATE_TEST_CASE_P(Service, GLES2DecoderTest2, ::testing::Bool());
+INSTANTIATE_TEST_CASE_P(Service, GLES3DecoderTest2, ::testing::Bool());
 
 template <>
 void GLES2DecoderTestBase::SpecializedSetup<cmds::GetProgramInfoLog, 0>(
     bool /* valid */) {
   const GLuint kClientVertexShaderId = 5001;
   const GLuint kServiceVertexShaderId = 6001;
   const GLuint kClientFragmentShaderId = 5002;
   const GLuint kServiceFragmentShaderId = 6002;
   const char* log = "hello";  // Matches auto-generated unit test.
   DoCreateShader(
@@ skipping 352 matching lines @@
 
 TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_INT_VEC4) {
   TestAcceptedUniform(GL_INT_VEC4, Program::kUniform4i, false);
 }
 
 TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_BOOL) {
   TestAcceptedUniform(
       GL_BOOL, Program::kUniform1i | Program::kUniform1f, false);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniformES3_GL_BOOL) {
+TEST_P(GLES3DecoderTest2, AcceptsUniformES3_GL_BOOL) {
   TestAcceptedUniform(
       GL_BOOL,
       Program::kUniform1i | Program::kUniform1f | Program::kUniform1ui,
       true);
 }
 
 TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_BOOL_VEC2) {
   TestAcceptedUniform(
       GL_BOOL_VEC2, Program::kUniform2i | Program::kUniform2f, false);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniformES3_GL_BOOL_VEC2) {
+TEST_P(GLES3DecoderTest2, AcceptsUniformES3_GL_BOOL_VEC2) {
   TestAcceptedUniform(
       GL_BOOL_VEC2,
       Program::kUniform2i | Program::kUniform2f | Program::kUniform2ui,
       true);
 }
 
 TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_BOOL_VEC3) {
   TestAcceptedUniform(
       GL_BOOL_VEC3, Program::kUniform3i | Program::kUniform3f, false);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniformES3_GL_BOOL_VEC3) {
+TEST_P(GLES3DecoderTest2, AcceptsUniformES3_GL_BOOL_VEC3) {
   TestAcceptedUniform(
       GL_BOOL_VEC3,
       Program::kUniform3i | Program::kUniform3f | Program::kUniform3ui,
       true);
 }
 
 TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_BOOL_VEC4) {
   TestAcceptedUniform(
       GL_BOOL_VEC4, Program::kUniform4i | Program::kUniform4f, false);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniformES3_GL_BOOL_VEC4) {
+TEST_P(GLES3DecoderTest2, AcceptsUniformES3_GL_BOOL_VEC4) {
   TestAcceptedUniform(
       GL_BOOL_VEC4,
       Program::kUniform4i | Program::kUniform4f | Program::kUniform4ui,
       true);
 }
 
 TEST_P(GLES2DecoderTest2, AcceptsUniformTypeFLOAT) {
   TestAcceptedUniform(GL_FLOAT, Program::kUniform1f, false);
 }
 
@@ skipping 14 matching lines @@
 }
 
 TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_FLOAT_MAT3) {
   TestAcceptedUniform(GL_FLOAT_MAT3, Program::kUniformMatrix3f, false);
 }
 
 TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_FLOAT_MAT4) {
   TestAcceptedUniform(GL_FLOAT_MAT4, Program::kUniformMatrix4f, false);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_UNSIGNED_INT) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_UNSIGNED_INT) {
   TestAcceptedUniform(GL_UNSIGNED_INT, Program::kUniform1ui, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_UNSIGNED_INT_VEC2) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_UNSIGNED_INT_VEC2) {
   TestAcceptedUniform(GL_UNSIGNED_INT_VEC2, Program::kUniform2ui, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_UNSIGNED_INT_VEC3) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_UNSIGNED_INT_VEC3) {
   TestAcceptedUniform(GL_UNSIGNED_INT_VEC3, Program::kUniform3ui, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_UNSIGNED_INT_VEC4) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_UNSIGNED_INT_VEC4) {
   TestAcceptedUniform(GL_UNSIGNED_INT_VEC4, Program::kUniform4ui, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_FLOAT_MAT2x3) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_FLOAT_MAT2x3) {
   TestAcceptedUniform(GL_FLOAT_MAT2x3, Program::kUniformMatrix2x3f, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_FLOAT_MAT2x4) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_FLOAT_MAT2x4) {
   TestAcceptedUniform(GL_FLOAT_MAT2x4, Program::kUniformMatrix2x4f, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_FLOAT_MAT3x2) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_FLOAT_MAT3x2) {
   TestAcceptedUniform(GL_FLOAT_MAT3x2, Program::kUniformMatrix3x2f, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_FLOAT_MAT3x4) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_FLOAT_MAT3x4) {
   TestAcceptedUniform(GL_FLOAT_MAT3x4, Program::kUniformMatrix3x4f, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_FLOAT_MAT4x2) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_FLOAT_MAT4x2) {
   TestAcceptedUniform(GL_FLOAT_MAT4x2, Program::kUniformMatrix4x2f, true);
 }
 
-TEST_P(GLES2DecoderTest2, AcceptsUniform_GL_FLOAT_MAT4x3) {
+TEST_P(GLES3DecoderTest2, AcceptsUniform_GL_FLOAT_MAT4x3) {
   TestAcceptedUniform(GL_FLOAT_MAT4x3, Program::kUniformMatrix4x3f, true);
 }
 
 }  // namespace gles2
 }  // namespace gpu