Allow spellcheck_test to run custom callback at completion

Allow spellcheck_test to run custom callback at completion

This patch allows spellcheck_test to take a callback argument, so that
we can perform certain actions (in most cases, a depending test) after
one test successfully finishes.

This patch is a preparation to convert more complicated spellchecking
layout tests, e.g., delete-misspelled-word.html

BUG=517298
Committed: https://crrev.com/634bf88f3eb252bde4418e119ecc660bf08d2296
Cr-Commit-Position: refs/heads/master@{#427644}

[Xiaocheng, 2016-10-26 07:21:41]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 07:21:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-26 07:24:15]

Description was changed from

==========
Allow spellcheck_test to run custom callback at completion

BUG=517298
==========

to

==========
Allow spellcheck_test to run custom callback at completion

This patch allows spellcheck_test to take a callback argument, so that
we can perform certain actions (in most cases, a depending test) after
one test successfully finishes.

This patch is a preparation to convert more complicated spellchecking
layout tests, e.g., delete-misspelled-word.html

BUG=517298
==========

[Xiaocheng, 2016-10-26 07:24:52]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-26 07:24:53]

PTAL.

Unfortunately spellcheck_test has to be more complicated...

[yosin_UTC9, 2016-10-26 07:50:20]

lgtm

I hope no tests use multiple callbacks. ;-)

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.html
(right):

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.html:56: var div
= document.querySelector('div');
nit: s/var/const/

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js (right):

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js:399: if
(typeof(passedArgs) == 'string') {
nit: s/==/===/

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js:404:
args[kTitle] = passedArgs[kTitle];
How about below?

[kTitle, kCallback].forEach(key => args[key] = passedArgs[key])

[Xiaocheng, 2016-10-26 08:01:16]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-10-26 08:01:17]

One callback already allows us to do everything.

Committing after following the suggestions.

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.html
(right):

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.html:56: var div
= document.querySelector('div');
On 2016/10/26 at 07:50:20, Yosi_UTC9 wrote:
> nit: s/var/const/

Done.

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js (right):

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js:399: if
(typeof(passedArgs) == 'string') {
On 2016/10/26 at 07:50:20, Yosi_UTC9 wrote:
> nit: s/==/===/

Done.

https://codereview.chromium.org/2445323005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js:404:
args[kTitle] = passedArgs[kTitle];
On 2016/10/26 at 07:50:20, Yosi_UTC9 wrote:
> How about below?
> 
> [kTitle, kCallback].forEach(key => args[key] = passedArgs[key])

Done.

[Xiaocheng, 2016-10-26 08:01:17]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2445323005/#ps40001
(title: "Wed Oct 26 16:59:50 JST 2016")

[commit-bot: I haz the power, 2016-10-26 08:01:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 08:59:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 09:02:50]

Description was changed from

==========
Allow spellcheck_test to run custom callback at completion

This patch allows spellcheck_test to take a callback argument, so that
we can perform certain actions (in most cases, a depending test) after
one test successfully finishes.

This patch is a preparation to convert more complicated spellchecking
layout tests, e.g., delete-misspelled-word.html

BUG=517298
==========

to

==========
Allow spellcheck_test to run custom callback at completion

This patch allows spellcheck_test to take a callback argument, so that
we can perform certain actions (in most cases, a depending test) after
one test successfully finishes.

This patch is a preparation to convert more complicated spellchecking
layout tests, e.g., delete-misspelled-word.html

BUG=517298

Committed: https://crrev.com/634bf88f3eb252bde4418e119ecc660bf08d2296
Cr-Commit-Position: refs/heads/master@{#427644}
==========

[commit-bot: I haz the power, 2016-10-26 09:02:51]

Patchset 3 (id:??) landed as
https://crrev.com/634bf88f3eb252bde4418e119ecc660bf08d2296
Cr-Commit-Position: refs/heads/master@{#427644}