Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2443143003:
Convert editing/spelling/delete-misspelled-word with spellcheck_test (Closed)
|
Created:
4 years, 1 month ago by Xiaocheng Modified:
4 years, 1 month ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConvert editing/spelling/delete-misspelled-word with spellcheck_test
This patch converts editing/spelling/delete-misspelled-word.html with
spellcheck_test as a preparation of implementing idle time spellchecker.
BUG=517298
Committed: https://crrev.com/dab6ec4a87341392b937d52d86990d0ecf7b690b
Cr-Commit-Position: refs/heads/master@{#427666}
Patch Set 1 #Patch Set 2 : Wed Oct 26 17:16:48 JST 2016 #
Depends on Patchset: Messages
Total messages: 20 (14 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL.
Description was changed from ========== Convert editing/spelling/delete-misspelled-word with spellcheck_test This patch converts editing/spelling/delete-misspelled-word.html with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 ========== to ========== Convert editing/spelling/delete-misspelled-word with spellcheck_test BLOCKED: we need to add support that performs certain actions and inspections after markers on initial text appear... This patch converts editing/spelling/delete-misspelled-word.html with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 ==========
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Description was changed from ========== Convert editing/spelling/delete-misspelled-word with spellcheck_test BLOCKED: we need to add support that performs certain actions and inspections after markers on initial text appear... This patch converts editing/spelling/delete-misspelled-word.html with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 ========== to ========== Convert editing/spelling/delete-misspelled-word with spellcheck_test This patch converts editing/spelling/delete-misspelled-word.html with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yosin@chromium.org
The CQ bit was checked by yosin@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2445323005 Patch 40001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Convert editing/spelling/delete-misspelled-word with spellcheck_test This patch converts editing/spelling/delete-misspelled-word.html with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 ========== to ========== Convert editing/spelling/delete-misspelled-word with spellcheck_test This patch converts editing/spelling/delete-misspelled-word.html with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/dab6ec4a87341392b937d52d86990d0ecf7b690b Cr-Commit-Position: refs/heads/master@{#427666} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/dab6ec4a87341392b937d52d86990d0ecf7b690b Cr-Commit-Position: refs/heads/master@{#427666} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
