Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2442313002: Convert editing/spelling/design-mode-spellcheck-off.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/design-mode-spellcheck-off.html with spellcheck_test This patch converts editing/spelling/design-mode-spellcheck-off.html with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/e0e0a7f9d4b7719dcd3606cd690d2f1dbe222f05 Cr-Commit-Position: refs/heads/master@{#427665}

Patch Set 1 #

Patch Set 2 : Wed Oct 26 17:56:37 JST 2016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -55 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/design-mode-spellcheck-off.html View 1 1 chunk +35 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/design-mode-spellcheck-off-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-25 01:21:19 UTC) #6
yosin_UTC9
lgtm
4 years, 1 month ago (2016-10-26 09:02:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442313002/20001
4 years, 1 month ago (2016-10-26 09:02:37 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 10:52:08 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 10:53:44 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0e0a7f9d4b7719dcd3606cd690d2f1dbe222f05
Cr-Commit-Position: refs/heads/master@{#427665}

Powered by Google App Engine
This is Rietveld 408576698