Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: Source/core/html/track/vtt/VTTParser.cpp

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTParser.cpp
diff --git a/Source/core/html/track/vtt/VTTParser.cpp b/Source/core/html/track/vtt/VTTParser.cpp
index 6cb7c45f807bdc580d0cef8e61008d7730677211..62f73699fdd019d9baeabc62e7cb2ec998246847 100644
--- a/Source/core/html/track/vtt/VTTParser.cpp
+++ b/Source/core/html/track/vtt/VTTParser.cpp
@@ -89,13 +89,13 @@ VTTParser::VTTParser(VTTParserClient* client, Document& document)
{
}
-void VTTParser::getNewCues(Vector<RefPtr<VTTCue> >& outputCues)
+void VTTParser::getNewCues(WillBeHeapVector<RefPtrWillBeMember<VTTCue> >& outputCues)
{
- outputCues = m_cuelist;
- m_cuelist.clear();
+ outputCues = m_cueList;
+ m_cueList.clear();
}
-void VTTParser::getNewRegions(Vector<RefPtr<VTTRegion> >& outputRegions)
+void VTTParser::getNewRegions(WillBeHeapVector<RefPtrWillBeMember<VTTRegion> >& outputRegions)
{
outputRegions = m_regionList;
m_regionList.clear();
@@ -363,11 +363,11 @@ PassRefPtr<DocumentFragment> VTTParser::createDocumentFragmentFromCueText(Docume
void VTTParser::createNewCue()
{
- RefPtr<VTTCue> cue = VTTCue::create(*m_document, m_currentStartTime, m_currentEndTime, m_currentContent.toString());
+ RefPtrWillBeRawPtr<VTTCue> cue = VTTCue::create(*m_document, m_currentStartTime, m_currentEndTime, m_currentContent.toString());
cue->setId(m_currentId);
cue->parseSettings(m_currentSettings);
- m_cuelist.append(cue);
+ m_cueList.append(cue);
if (m_client)
m_client->newCuesParsed();
}
@@ -387,7 +387,7 @@ void VTTParser::createNewRegion(const String& headerValue)
return;
// Steps 12.5.1 - 12.5.9 - Construct and initialize a WebVTT Region object.
- RefPtr<VTTRegion> region = VTTRegion::create();
+ RefPtrWillBeRawPtr<VTTRegion> region = VTTRegion::create();
region->setRegionSettings(headerValue);
// Step 12.5.10 If the text track list of regions regions contains a region
@@ -557,5 +557,10 @@ void VTTTreeBuilder::constructTreeFromToken(Document& document)
}
}
+void VTTParser::trace(Visitor* visitor)
+{
+ visitor->trace(m_cueList);
+ visitor->trace(m_regionList);
}
+}

Powered by Google App Engine
This is Rietveld 408576698