Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: Source/core/html/track/vtt/VTTRegionList.h

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTRegionList.h
diff --git a/Source/core/html/track/vtt/VTTRegionList.h b/Source/core/html/track/vtt/VTTRegionList.h
index 35e1b8e8d47f66fa765203dffe8eea3034347f5a..caff22b96895173b12eaca00eb2c7f7ec1048bf5 100644
--- a/Source/core/html/track/vtt/VTTRegionList.h
+++ b/Source/core/html/track/vtt/VTTRegionList.h
@@ -33,28 +33,28 @@
namespace WebCore {
-class VTTRegionList : public RefCounted<VTTRegionList> {
+class VTTRegionList FINAL : public RefCountedWillBeGarbageCollected<VTTRegionList> {
public:
- static PassRefPtr<VTTRegionList> create()
+ static PassRefPtrWillBeRawPtr<VTTRegionList> create()
{
- return adoptRef(new VTTRegionList());
+ return adoptRefWillBeNoop(new VTTRegionList());
}
- ~VTTRegionList() { }
-
unsigned long length() const;
VTTRegion* item(unsigned index) const;
VTTRegion* getRegionById(const String&) const;
- void add(PassRefPtr<VTTRegion>);
+ void add(PassRefPtrWillBeRawPtr<VTTRegion>);
bool remove(VTTRegion*);
+ void trace(Visitor*);
+
private:
VTTRegionList();
void clear();
haraken 2014/04/22 02:37:47 This clear() method is unused. You can remove it.
sof 2014/04/22 06:27:52 Nice; removed.
- Vector<RefPtr<VTTRegion> > m_list;
+ WillBeHeapVector<RefPtrWillBeMember<VTTRegion> > m_list;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698