Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: Source/core/html/track/vtt/VTTParser.h

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTParser.h
diff --git a/Source/core/html/track/vtt/VTTParser.h b/Source/core/html/track/vtt/VTTParser.h
index 93170e1b81bd5f38c1cb0a310e48c6029160b0df..7c94845bfd9a2db994df2df2dcb1fb0310f1b07f 100644
--- a/Source/core/html/track/vtt/VTTParser.h
+++ b/Source/core/html/track/vtt/VTTParser.h
@@ -39,6 +39,7 @@
#include "core/html/track/vtt/VTTCue.h"
#include "core/html/track/vtt/VTTRegion.h"
#include "core/html/track/vtt/VTTTokenizer.h"
+#include "platform/heap/Handle.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/text/StringBuilder.h"
@@ -56,7 +57,7 @@ public:
virtual void fileFailedToParse() = 0;
};
-class VTTParser FINAL {
+class VTTParser FINAL : public NoBaseWillBeGarbageCollectedFinalized<VTTParser> {
public:
enum ParseState {
Initial,
@@ -67,9 +68,9 @@ public:
BadCue
};
- static PassOwnPtr<VTTParser> create(VTTParserClient* client, Document& document)
+ static PassOwnPtrWillBeRawPtr<VTTParser> create(VTTParserClient* client, Document& document)
{
- return adoptPtr(new VTTParser(client, document));
+ return adoptPtrWillBeNoop(new VTTParser(client, document));
}
static inline bool isRecognizedTag(const AtomicString& tagName)
@@ -105,8 +106,10 @@ public:
void flush();
// Transfers ownership of last parsed cues to caller.
- void getNewCues(Vector<RefPtr<VTTCue> >&);
- void getNewRegions(Vector<RefPtr<VTTRegion> >&);
+ void getNewCues(WillBeHeapVector<RefPtrWillBeMember<VTTCue> >&);
+ void getNewRegions(WillBeHeapVector<RefPtrWillBeMember<VTTRegion> >&);
+
+ void trace(Visitor*);
private:
VTTParser(VTTParserClient*, Document&);
@@ -141,9 +144,9 @@ private:
VTTParserClient* m_client;
- Vector<RefPtr<VTTCue> > m_cuelist;
+ WillBeHeapVector<RefPtrWillBeMember<VTTCue> > m_cueList;
- Vector<RefPtr<VTTRegion> > m_regionList;
+ WillBeHeapVector<RefPtrWillBeMember<VTTRegion> > m_regionList;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698