Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2444753002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce usage of FOR_EACH_OBSERVER macro in components/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/42b92c1829a49c1eb82231776b9ef94481da0257 Cr-Commit-Position: refs/heads/master@{#427133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -95 lines) Patch
M components/ntp_snippets/content_suggestions_service.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_proxy.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M components/offline_pages/downloads/download_ui_adapter.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M components/omnibox/browser/omnibox_popup_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/shortcuts_backend.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M components/pairing/fake_controller_pairing_controller.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M components/pairing/fake_host_pairing_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/physical_web/data_source/physical_web_data_source_impl.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M components/prefs/default_pref_store.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/prefs/in_memory_pref_store.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/prefs/json_pref_store.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M components/prefs/overlay_user_pref_store.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/prefs/pref_notifier_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/prefs/testing_pref_store.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M components/prefs/value_map_pref_store.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-23 23:31:48 UTC) #4
blundell
lgtm
4 years, 1 month ago (2016-10-24 16:13:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444753002/1
4 years, 1 month ago (2016-10-24 20:02:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 20:21:39 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 20:25:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42b92c1829a49c1eb82231776b9ef94481da0257
Cr-Commit-Position: refs/heads/master@{#427133}

Powered by Google App Engine
This is Rietveld 408576698