Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Side by Side Diff: components/prefs/default_pref_store.cc

Issue 2444753002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/prefs/default_pref_store.h" 5 #include "components/prefs/default_pref_store.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 10
(...skipping 23 matching lines...) Expand all
34 DCHECK(!GetValue(key, NULL)); 34 DCHECK(!GetValue(key, NULL));
35 prefs_.SetValue(key, std::move(value)); 35 prefs_.SetValue(key, std::move(value));
36 } 36 }
37 37
38 void DefaultPrefStore::ReplaceDefaultValue(const std::string& key, 38 void DefaultPrefStore::ReplaceDefaultValue(const std::string& key,
39 std::unique_ptr<Value> value) { 39 std::unique_ptr<Value> value) {
40 const Value* old_value = NULL; 40 const Value* old_value = NULL;
41 GetValue(key, &old_value); 41 GetValue(key, &old_value);
42 bool notify = !old_value->Equals(value.get()); 42 bool notify = !old_value->Equals(value.get());
43 prefs_.SetValue(key, std::move(value)); 43 prefs_.SetValue(key, std::move(value));
44 if (notify) 44 if (notify) {
45 FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key)); 45 for (Observer& observer : observers_)
46 observer.OnPrefValueChanged(key);
47 }
46 } 48 }
47 49
48 DefaultPrefStore::const_iterator DefaultPrefStore::begin() const { 50 DefaultPrefStore::const_iterator DefaultPrefStore::begin() const {
49 return prefs_.begin(); 51 return prefs_.begin();
50 } 52 }
51 53
52 DefaultPrefStore::const_iterator DefaultPrefStore::end() const { 54 DefaultPrefStore::const_iterator DefaultPrefStore::end() const {
53 return prefs_.end(); 55 return prefs_.end();
54 } 56 }
55 57
56 DefaultPrefStore::~DefaultPrefStore() {} 58 DefaultPrefStore::~DefaultPrefStore() {}
OLDNEW
« no previous file with comments | « components/physical_web/data_source/physical_web_data_source_impl.cc ('k') | components/prefs/in_memory_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698