Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: components/offline_pages/background/request_coordinator.cc

Issue 2444753002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_coordinator.h" 5 #include "components/offline_pages/background/request_coordinator.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 737 matching lines...) Expand 10 before | Expand all | Expand 10 after
748 void RequestCoordinator::AddObserver(Observer* observer) { 748 void RequestCoordinator::AddObserver(Observer* observer) {
749 DCHECK(observer); 749 DCHECK(observer);
750 observers_.AddObserver(observer); 750 observers_.AddObserver(observer);
751 } 751 }
752 752
753 void RequestCoordinator::RemoveObserver(Observer* observer) { 753 void RequestCoordinator::RemoveObserver(Observer* observer) {
754 observers_.RemoveObserver(observer); 754 observers_.RemoveObserver(observer);
755 } 755 }
756 756
757 void RequestCoordinator::NotifyAdded(const SavePageRequest& request) { 757 void RequestCoordinator::NotifyAdded(const SavePageRequest& request) {
758 FOR_EACH_OBSERVER(Observer, observers_, OnAdded(request)); 758 for (Observer& observer : observers_)
759 observer.OnAdded(request);
759 } 760 }
760 761
761 void RequestCoordinator::NotifyCompleted(const SavePageRequest& request, 762 void RequestCoordinator::NotifyCompleted(const SavePageRequest& request,
762 BackgroundSavePageResult status) { 763 BackgroundSavePageResult status) {
763 FOR_EACH_OBSERVER(Observer, observers_, OnCompleted(request, status)); 764 for (Observer& observer : observers_)
765 observer.OnCompleted(request, status);
764 } 766 }
765 767
766 void RequestCoordinator::NotifyChanged(const SavePageRequest& request) { 768 void RequestCoordinator::NotifyChanged(const SavePageRequest& request) {
767 FOR_EACH_OBSERVER(Observer, observers_, OnChanged(request)); 769 for (Observer& observer : observers_)
770 observer.OnChanged(request);
768 } 771 }
769 772
770 void RequestCoordinator::GetOffliner() { 773 void RequestCoordinator::GetOffliner() {
771 if (!offliner_) { 774 if (!offliner_) {
772 offliner_ = factory_->GetOffliner(policy_.get()); 775 offliner_ = factory_->GetOffliner(policy_.get());
773 } 776 }
774 } 777 }
775 778
776 ClientPolicyController* RequestCoordinator::GetPolicyController() { 779 ClientPolicyController* RequestCoordinator::GetPolicyController() {
777 return policy_controller_.get(); 780 return policy_controller_.get();
778 } 781 }
779 782
780 void RequestCoordinator::Shutdown() { 783 void RequestCoordinator::Shutdown() {
781 network_quality_estimator_ = nullptr; 784 network_quality_estimator_ = nullptr;
782 } 785 }
783 786
784 } // namespace offline_pages 787 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/ntp_snippets/offline_pages/offline_page_proxy.cc ('k') | components/offline_pages/downloads/download_ui_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698