Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 24440002: Bench baseline for mostly 0 image. (Closed)

Created:
7 years, 3 months ago by scroggo
Modified:
7 years, 2 months ago
Reviewers:
mtklein, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Bench baseline for mostly 0 image. Add a baseline for decoding a mostly 0 image. This is in advance of https://codereview.chromium.org/24269006/ which provides an option to skip writing those 0s (as part of BUG=skia:1661 ). On my Nexus 4, the benchmark does not slow down after that change. As suggested in https://codereview.chromium.org/24269006/ add a resourcePath flag to bench. Will require a change in buildbot in order to actually use the flag. Add an image used by the test. Until https://codereview.chromium.org/24448002 is submitted, the test will not actually be run by the bots (since it won't know where to find the file). BUG=skia:1661 R=djsollen@google.com, mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=11461

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Respond to comments and prevent crash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1 line) Patch
M bench/SkBenchmark.h View 3 chunks +6 lines, -0 lines 0 comments Download
M bench/SkBenchmark.cpp View 2 chunks +2 lines, -1 line 0 comments Download
A bench/SkipZeroesBench.cpp View 1 1 chunk +115 lines, -0 lines 0 comments Download
M bench/benchmain.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A resources/arrow.png View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
7 years, 3 months ago (2013-09-24 21:49:53 UTC) #1
djsollen
lgtm
7 years, 2 months ago (2013-09-25 13:38:25 UTC) #2
mtklein
lgtm https://codereview.chromium.org/24440002/diff/8001/bench/SkipZeroesBench.cpp File bench/SkipZeroesBench.cpp (right): https://codereview.chromium.org/24440002/diff/8001/bench/SkipZeroesBench.cpp#newcode101 bench/SkipZeroesBench.cpp:101: SkImageDecoder* fDecoder; SkAutoTDelete?
7 years, 2 months ago (2013-09-25 13:48:31 UTC) #3
scroggo
https://codereview.chromium.org/24440002/diff/8001/bench/SkipZeroesBench.cpp File bench/SkipZeroesBench.cpp (right): https://codereview.chromium.org/24440002/diff/8001/bench/SkipZeroesBench.cpp#newcode101 bench/SkipZeroesBench.cpp:101: SkImageDecoder* fDecoder; On 2013/09/25 13:48:32, mtklein wrote: > SkAutoTDelete? ...
7 years, 2 months ago (2013-09-25 17:54:57 UTC) #4
scroggo
7 years, 2 months ago (2013-09-25 21:42:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r11461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698