Issue 24448002: Supply resource path for bench.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24448002: Supply resource path for bench. (Closed)

Created:
7 years, 3 months ago by scroggo

Modified:
7 years, 2 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/buildbot

Visibility:
Public.

More Reviews

Description

Supply resource path for bench. Required for SkipZeroesBench to decode the right file. Depends on https://codereview.chromium.org/24440002/ to add the resourcePath flag. R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=11490

Patch Set 2 : Respond to comments #

Patch Set 3 : Should be the same. From a different computer. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	slave/skia_slave_scripts/run_bench.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

borenet

LGTM https://codereview.chromium.org/24448002/diff/3001/slave/skia_slave_scripts/run_bench.py File slave/skia_slave_scripts/run_bench.py (right): https://codereview.chromium.org/24448002/diff/3001/slave/skia_slave_scripts/run_bench.py#newcode54 slave/skia_slave_scripts/run_bench.py:54: args.extend(['-i ', self._device_dirs.ResourceDir()]) Optional: You can replace the ...

7 years, 2 months ago (2013-09-25 15:11:14 UTC) #2

scroggo

https://codereview.chromium.org/24448002/diff/3001/slave/skia_slave_scripts/run_bench.py File slave/skia_slave_scripts/run_bench.py (right): https://codereview.chromium.org/24448002/diff/3001/slave/skia_slave_scripts/run_bench.py#newcode54 slave/skia_slave_scripts/run_bench.py:54: args.extend(['-i ', self._device_dirs.ResourceDir()]) On 2013/09/25 15:11:14, borenet wrote: > ...

7 years, 2 months ago (2013-09-25 19:43:57 UTC) #3