Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 244383002: Fix field type handling in load elimination. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Fix field type handling in load elimination. Drive-by-fix: map_set() must return a pointer to the UniqueSet instead of a copy. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/hydrogen-check-elimination.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-load-elimination.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/unique.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Easy starter for the new week :-) PTAL
6 years, 8 months ago (2014-04-20 11:13:05 UTC) #1
Sven Panne
LGTM, although this CL is actually 2 CLs, and the bigger part is the "drive-by ...
6 years, 8 months ago (2014-04-22 07:11:02 UTC) #2
Benedikt Meurer
6 years, 8 months ago (2014-04-22 07:24:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698