Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 244383002: Fix field type handling in load elimination. (Closed) Base URL: git@github.com:v8/v8.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen-load-elimination.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5620 matching lines...) Expand 10 before | Expand all | Expand 10 after
5631 LOperand* input = instr->value(); 5631 LOperand* input = instr->value();
5632 ASSERT(input->IsRegister()); 5632 ASSERT(input->IsRegister());
5633 Register reg = ToRegister(input); 5633 Register reg = ToRegister(input);
5634 5634
5635 DeferredCheckMaps* deferred = NULL; 5635 DeferredCheckMaps* deferred = NULL;
5636 if (instr->hydrogen()->has_migration_target()) { 5636 if (instr->hydrogen()->has_migration_target()) {
5637 deferred = new(zone()) DeferredCheckMaps(this, instr, reg, x87_stack_); 5637 deferred = new(zone()) DeferredCheckMaps(this, instr, reg, x87_stack_);
5638 __ bind(deferred->check_maps()); 5638 __ bind(deferred->check_maps());
5639 } 5639 }
5640 5640
5641 UniqueSet<Map> map_set = instr->hydrogen()->map_set(); 5641 const UniqueSet<Map>* map_set = instr->hydrogen()->map_set();
5642 Label success; 5642 Label success;
5643 for (int i = 0; i < map_set.size() - 1; i++) { 5643 for (int i = 0; i < map_set->size() - 1; i++) {
5644 Handle<Map> map = map_set.at(i).handle(); 5644 Handle<Map> map = map_set->at(i).handle();
5645 __ CompareMap(reg, map); 5645 __ CompareMap(reg, map);
5646 __ j(equal, &success, Label::kNear); 5646 __ j(equal, &success, Label::kNear);
5647 } 5647 }
5648 5648
5649 Handle<Map> map = map_set.at(map_set.size() - 1).handle(); 5649 Handle<Map> map = map_set->at(map_set->size() - 1).handle();
5650 __ CompareMap(reg, map); 5650 __ CompareMap(reg, map);
5651 if (instr->hydrogen()->has_migration_target()) { 5651 if (instr->hydrogen()->has_migration_target()) {
5652 __ j(not_equal, deferred->entry()); 5652 __ j(not_equal, deferred->entry());
5653 } else { 5653 } else {
5654 DeoptimizeIf(not_equal, instr->environment()); 5654 DeoptimizeIf(not_equal, instr->environment());
5655 } 5655 }
5656 5656
5657 __ bind(&success); 5657 __ bind(&success);
5658 } 5658 }
5659 5659
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
6449 __ bind(deferred->exit()); 6449 __ bind(deferred->exit());
6450 __ bind(&done); 6450 __ bind(&done);
6451 } 6451 }
6452 6452
6453 6453
6454 #undef __ 6454 #undef __
6455 6455
6456 } } // namespace v8::internal 6456 } } // namespace v8::internal
6457 6457
6458 #endif // V8_TARGET_ARCH_IA32 6458 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-load-elimination.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698