Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 244383002: Fix field type handling in load elimination. (Closed) Base URL: git@github.com:v8/v8.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5172 matching lines...) Expand 10 before | Expand all | Expand 10 after
5183 Register reg = ToRegister(input); 5183 Register reg = ToRegister(input);
5184 5184
5185 __ ldr(map_reg, FieldMemOperand(reg, HeapObject::kMapOffset)); 5185 __ ldr(map_reg, FieldMemOperand(reg, HeapObject::kMapOffset));
5186 5186
5187 DeferredCheckMaps* deferred = NULL; 5187 DeferredCheckMaps* deferred = NULL;
5188 if (instr->hydrogen()->has_migration_target()) { 5188 if (instr->hydrogen()->has_migration_target()) {
5189 deferred = new(zone()) DeferredCheckMaps(this, instr, reg); 5189 deferred = new(zone()) DeferredCheckMaps(this, instr, reg);
5190 __ bind(deferred->check_maps()); 5190 __ bind(deferred->check_maps());
5191 } 5191 }
5192 5192
5193 UniqueSet<Map> map_set = instr->hydrogen()->map_set(); 5193 const UniqueSet<Map>* map_set = instr->hydrogen()->map_set();
5194 Label success; 5194 Label success;
5195 for (int i = 0; i < map_set.size() - 1; i++) { 5195 for (int i = 0; i < map_set->size() - 1; i++) {
5196 Handle<Map> map = map_set.at(i).handle(); 5196 Handle<Map> map = map_set->at(i).handle();
5197 __ CompareMap(map_reg, map, &success); 5197 __ CompareMap(map_reg, map, &success);
5198 __ b(eq, &success); 5198 __ b(eq, &success);
5199 } 5199 }
5200 5200
5201 Handle<Map> map = map_set.at(map_set.size() - 1).handle(); 5201 Handle<Map> map = map_set->at(map_set->size() - 1).handle();
5202 __ CompareMap(map_reg, map, &success); 5202 __ CompareMap(map_reg, map, &success);
5203 if (instr->hydrogen()->has_migration_target()) { 5203 if (instr->hydrogen()->has_migration_target()) {
5204 __ b(ne, deferred->entry()); 5204 __ b(ne, deferred->entry());
5205 } else { 5205 } else {
5206 DeoptimizeIf(ne, instr->environment()); 5206 DeoptimizeIf(ne, instr->environment());
5207 } 5207 }
5208 5208
5209 __ bind(&success); 5209 __ bind(&success);
5210 } 5210 }
5211 5211
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
5864 __ ldr(result, FieldMemOperand(scratch, 5864 __ ldr(result, FieldMemOperand(scratch,
5865 FixedArray::kHeaderSize - kPointerSize)); 5865 FixedArray::kHeaderSize - kPointerSize));
5866 __ bind(deferred->exit()); 5866 __ bind(deferred->exit());
5867 __ bind(&done); 5867 __ bind(&done);
5868 } 5868 }
5869 5869
5870 5870
5871 #undef __ 5871 #undef __
5872 5872
5873 } } // namespace v8::internal 5873 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698