Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2443173002: Convert editing/spelling/grammar-edit-word.html (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/grammar-edit-word.html This patch converts editing/spelling/grammar-edit-word.html with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/e28fb8ac3c43684626780aeeb495e748123b3bcb Cr-Commit-Position: refs/heads/master@{#427668}

Patch Set 1 #

Patch Set 2 : Wed Oct 26 17:09:36 JST 2016 #

Total comments: 2

Patch Set 3 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -47 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html View 1 2 1 chunk +21 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (12 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-25 01:20:33 UTC) #6
yosin_UTC9
lgtm w/ small nit https://codereview.chromium.org/2443173002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html File third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html (right): https://codereview.chromium.org/2443173002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html#newcode17 third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html:17: for (var i = 0; ...
4 years, 1 month ago (2016-10-26 08:15:33 UTC) #9
Xiaocheng
Thanks. https://codereview.chromium.org/2443173002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html File third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html (right): https://codereview.chromium.org/2443173002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html#newcode17 third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html:17: for (var i = 0; i < 12; ...
4 years, 1 month ago (2016-10-26 08:19:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443173002/40001
4 years, 1 month ago (2016-10-26 09:00:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/319368)
4 years, 1 month ago (2016-10-26 10:10:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443173002/40001
4 years, 1 month ago (2016-10-26 10:21:54 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-26 11:15:30 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 11:17:55 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e28fb8ac3c43684626780aeeb495e748123b3bcb
Cr-Commit-Position: refs/heads/master@{#427668}

Powered by Google App Engine
This is Rietveld 408576698