Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/stopNotifications/device-reconnects-during-success.html

Issue 2443063002: bluetooth: Require frame to be connected for stopNotifications to succeed. (Closed)
Patch Set: Fix test expectations Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/stopNotifications/device-reconnects-during-success.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/writeValue/gen-gatt-op-device-reconnects-during-success.html b/third_party/WebKit/LayoutTests/bluetooth/stopNotifications/device-reconnects-during-success.html
similarity index 80%
copy from third_party/WebKit/LayoutTests/bluetooth/writeValue/gen-gatt-op-device-reconnects-during-success.html
copy to third_party/WebKit/LayoutTests/bluetooth/stopNotifications/device-reconnects-during-success.html
index 4a6d1e3e1b489e65fa99158457c3cbf3c8a52c52..dab09da67ebdbf367129baf859cde3b0310a32bf 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/writeValue/gen-gatt-op-device-reconnects-during-success.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/stopNotifications/device-reconnects-during-success.html
@@ -6,22 +6,23 @@
<script>
promise_test(() => {
let val = new Uint8Array([1]);
- return setBluetoothFakeAdapter('DisconnectingDuringSuccessGATTOperationAdapter')
+ return setBluetoothFakeAdapter('DisconnectingDuringStopNotifySessionAdapter')
.then(() => requestDeviceWithKeyDown({
filters: [{services: ['health_thermometer']}]}))
.then(device => device.gatt.connect())
.then(gatt => gatt.getPrimaryService('health_thermometer'))
.then(service => service.getCharacteristic('measurement_interval'))
+ .then(characteristic => characteristic.startNotifications())
.then(characteristic => {
let disconnected = eventPromise(characteristic.service.device, 'gattserverdisconnected');
let promise = assert_promise_rejects_with_message(
- characteristic.writeValue(val),
+ characteristic.stopNotifications(),
new DOMException('GATT Server disconnected while performing a GATT operation.',
'NetworkError'));
return disconnected.then(() => characteristic.service.device.gatt.connect())
.then(() => promise);
});
-}, 'Device reconnects during a writeValue call that succeeds. Reject ' +
+}, 'Device reconnects during a stopNotifications call that succeeds. Reject ' +
'with NetworkError.');
</script>

Powered by Google App Engine
This is Rietveld 408576698