Index: README.chromium |
diff --git a/README.chromium b/README.chromium |
index b49691ad1209da8f43bc906bffe40faf4295cfb1..8b69597db5f85a521ac20c9d16bddb881a9f8620 100644 |
--- a/README.chromium |
+++ b/README.chromium |
@@ -4,17 +4,12 @@ Version: 58.1 |
License: MIT |
Security Critical: yes |
-WARNING: ICU is in the middle of being updated to 58.1. DEPS-roll to |
-ToT WOULD NOT work until the update is completed. Do not roll icu to the |
-ToT. If you need to make a change in ICU 56, contact jshin@chromium.org |
-(jungshik at google) to make a branch. |
- |
Description: |
This directory contains the source code of ICU 58.1 for C/C++. |
A. How to update ICU |
-1. Run "scripts/update.sh <version>" (e.g. 56-1). |
+1. Run "scripts/update.sh <version>" (e.g. 58-1). |
This will download ICU from the upstream svn repository. |
It does preserve Chrome-specific build files (*local.mk) and |
converter files. (see section C) |
@@ -101,20 +96,20 @@ Pre-built data files are generated and checked in with the following steps |
Follow these steps to build windows/icudt.dll. By default, we set |
icu_use_icu_data_flag to 1 and don't use this file. |
- a. check out a clean copy of icu56 from the upstream on Windows |
+ a. check out a clean copy of icu58 from the upstream on Windows |
outside the Chrome tree. |
- $ svn export --native-eol LF http://source.icu-project.org/repos/icu/icu/tags/release-56-1 ${SEPARATE_ICU_ROOT}/icu56 |
+ $ svn export --native-eol LF http://source.icu-project.org/repos/icu/icu/tags/release-58-1 ${SEPARATE_ICU_ROOT}/icu58 |
b. copy ${CHROME_ICU_ROOT}/common/icudtl.dat to |
- ${SEPARATE_ICU_ROOT}/source/data/in/icudt56l.dat |
+ ${SEPARATE_ICU_ROOT}/source/data/in/icudt58l.dat |
c. copy ${CHROME_ICU_ROOT}/source/data/makedata.mak to |
${SEPARATE_ICU_ROOT}/source/data/makedata.mak |
c. In Visual Studio, open source/allinone/allinone.sln solution |
in ${SEPARATE_ICU_ROOT} |
d. Build 'makedata' target |
- e. icudt56.dll will be generated in ${SEPARATE_ICU_ROOT}/bin |
- f. Copy that icudt56.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll |
+ e. icudt58.dll will be generated in ${SEPARATE_ICU_ROOT}/bin |
+ f. Copy that icudt58.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll |
and check that in. |
3. Note on the locale data customization |
@@ -203,20 +198,7 @@ D. Local Modifications |
- patches/locale1.patch: Minor fixes for Korean |
-2. Applied post-56 fixes from the upstream for measure/date format bugs |
- |
- - patches/measure_format.patch: combined patch of 12 CLs taken |
- from bugs below. |
- - upstream bugs |
- http://bugs.icu-project.org/trac/ticket/11986 |
- http://bugs.icu-project.org/trac/ticket/12031 |
- http://bugs.icu-project.org/trac/ticket/12030 |
- http://bugs.icu-project.org/trac/ticket/12041 |
- |
- - patches/relative_date.patch from Android |
- https://android.googlesource.com/platform/external/icu/+/f9ffd5b%5E%21 |
- |
-3. Breakiterator patches |
+2. Breakiterator patches |
- patches/linebrk.patch |
a. Drop *_loose.txt for all locales and use the corresponding normal.txt |
b. Drop local patches we used to have for the following issues. They'll |
@@ -239,7 +221,7 @@ D. Local Modifications |
patch: patches/cjdict.patch |
upstream bug: http://bugs.icu-project.org/trac/ticket/10888 |
-4. Timezone data update |
+3. Timezone data update |
Run scripts/update_tz.sh to grab the latest version of the |
following timezone data files and put them in source/data/misc |
@@ -248,20 +230,17 @@ D. Local Modifications |
windowsZones.txt |
zoneinfo64.txt |
- As of July 26, 2016, the latest version is 2016f and the above files |
+ As of Oct 21, 2016, the latest version is 2016h and the above files |
are available at |
- http://source.icu-project.org/repos/icu/data/trunk/tzdata/icunew/2016f/44/ |
+ http://source.icu-project.org/repos/icu/data/trunk/tzdata/icunew/2016h/44/ |
-5. Build-related changes |
+4. Build-related changes |
- - patches/wpo.patch |
+ - patches/wpo.patch (only needed when icudata dll is used). |
upstream bugs : http://bugs.icu-project.org/trac/ticket/8043 |
http://bugs.icu-project.org/trac/ticket/5701 |
- - patches/vscomp.patch for building with Visual Studio on Windows. |
- a. do not use WINDOWS_LOCALE_API in locmap.c |
- b. do not redefine stringpiece::npos |
- c. fix http://bugs.icu-project.org/trac/ticket/12129 (C4138 warning) |
- d. fix http://bugs.icu-project.org/trac/ticket/11893 (C4275 warning) |
+ - patches/vscomp.patch for building with Visual Studio on Windows: |
+ do not use WINDOWS_LOCALE_API in locmap.c |
- patches/data.build.patch : |
Remove unnecessary resources : unames, collator rule source |
@@ -271,17 +250,7 @@ D. Local Modifications |
Put ICU_DATA_ENTRY_POINT(icudtXX_dat) in common when we use |
the icu data file or icudt.dll |
-6. Apply a timezone detection API fix |
- - patches/tzdetect.patch |
- - upstream bugs |
- http://bugs.icu-project.org/trac/ticket/11623 |
- |
-7. Fix 'bad cast' found in Transliterator with a cfi build |
- - patches/xlit_badcast.patch |
- - upstream bug (fixed in the upstream. Will be in ICU 57 release) |
- http://bugs.icu-project.org/trac/ticket/11937 |
- |
-8. Add back UTF-32 converters temporarily even when |
+5. Add back UTF-32 converters temporarily even when |
UCONFIG_ONLY_HTML_CONVERSION is defined until UTF-32 is |
removed from Blink. See |
http://www.icu-project.org/trac/ticket/11296 and |
@@ -289,33 +258,11 @@ D. Local Modifications |
- patches/utf32.patch |
-9. Fix a UText bug found in uregex_open fuzzer. |
- - patches/utext.patch |
- - upstream bug (fixed in trunk in Jan, 2016. Will be in ICU 57 release) |
- http://bugs.icu-project.org/trac/ticket/12130 |
- |
-10. Fix a bug in regex compiler. |
- - patches/regexcmp.patch |
- - upstream bug (fixed in the upstream. Will be in ICU 57 release) |
- http://bugs.icu-project.org/trac/ticket/12138 |
- |
-11. Remove an unnecessary static initializer |
- - patches/remove_si.patch |
- - upstream bug (fixed in trunk. Will be in ICU 57 release) |
- http://bugs.icu-project.org/trac/ticket/12408 |
- |
-12. Cherry pick locale data fixes from the upstream and Android |
- - patches/locale_extra.patch |
- - upstream bugs |
- http://unicode.org/cldr/trac/ticket/9045 (en-AU date format) |
- http://unicode.org/cldr/trac/ticket/7969 (percent sign in ar and fa) |
- - Android patch for the 2nd bug |
- https://android.googlesource.com/platform/external/icu/+/56b2b8b |
- |
-13. Add Emoji properties support by cherry-picking from 57.1 |
- - patches/emoji_props.patch |
- - Upstream change cherry-picked |
- http://bugs.icu-project.org/trac/changeset/38183 |
- - source/data/in/{pnames,uprops}.icu were copied from the upstream, |
- but they're just for the record. Their contents are hard-coded |
- in the source files patched by the above patch. |
+6. Fix two bugs found in 58.1 that will fixed in 58.1 maintenance release |
+ |
+ upstream bugs: |
+ http://www.icu-project.org/trac/ticket/12825 (scriptset) |
+ http://www.icu-project.org/trac/ticket/12822 (without std::string on Win) |
+ |
+ - patches/scriptset.patch |
+ - patches/digilist.patch |