Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2107)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2442673002: Get rid of createVisibleSelection() taking one Position (Closed)
Patch Set: 2016-10-24T17:42:38 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index 7f07e42cdd127920c4dc9336024c32ecdbb05d92..71e4b6a7d4412fa5df768a36ebeeb4f98adc3213 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -72,17 +72,6 @@ VisibleSelection createVisibleSelection(const SelectionInDOMTree& selection) {
return VisibleSelection::create(selection);
}
-VisibleSelection createVisibleSelection(const Position& pos,
- TextAffinity affinity,
- bool isDirectional) {
- DCHECK(!needsLayoutTreeUpdate(pos));
- SelectionInDOMTree::Builder builder;
- builder.setAffinity(affinity).setIsDirectional(isDirectional);
- if (pos.isNotNull())
- builder.collapse(pos);
- return createVisibleSelection(builder.build());
-}
-
VisibleSelection createVisibleSelection(const Position& base,
const Position& extent,
TextAffinity affinity,

Powered by Google App Engine
This is Rietveld 408576698