Removing gpu::SyncToken usage from video capture pipeline, part 1.

Removing gpu::SyncToken usage from video capture pipeline, part 1.

The use of gpu::SyncToken has been added for the sake of capture into
textures, but is now useless. This patch removes all uses up to
`OnClientBufferFinished` (excluded).

BUG=653994
R=emircan@chromium.org

[emircan, 2016-10-24 21:45:28]

Trybots point at merge conflicts. Can you please run "git rebase-update" on your
checkout and reupload?

https://codereview.chromium.org/2442193002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_controller.cc (right):

https://codereview.chromium.org/2442193002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_controller.cc:49: class
SyncTokenClientImpl : public VideoFrame::SyncTokenClient {
Remove this class as well.

https://codereview.chromium.org/2442193002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_controller.cc:65: void
ReturnVideoFrame(const scoped_refptr<VideoFrame>& video_frame,
Remove this method as well.

https://codereview.chromium.org/2442193002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_controller.h (left):

https://codereview.chromium.org/2442193002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_controller.h:119: // the
renderer process. If the consumer provided resource utilization
Keep the last sentence about resource utilization.

https://codereview.chromium.org/2442193002/diff/20001/content/renderer/media/...
File content/renderer/media/video_capture_impl.cc (left):

https://codereview.chromium.org/2442193002/diff/20001/content/renderer/media/...
content/renderer/media/video_capture_impl.cc:455:
callback_to_io_thread.Run(*release_sync_token, consumer_resource_utilization);
callback_to_io_thread.Run(consumer_resource_utilization);

We still need to run this callback.

[Yoric, 2016-11-09 07:58:05]

I have updated the patch. Do I need to do something to inform @emircan that a
second review is needed?

[mcasas, 2016-11-09 17:05:57]

On 2016/11/09 07:58:05, Yoric wrote:
> I have updated the patch. Do I need to do something to inform @emircan that a
> second review is needed?
Usually the code is to address the comments,
then click on "Publish+Mail comments" and
write:

personA@: PTAL (at file bla.cc)
personB@: PTAL
etc


I launched some bots to see how they fare.
You can remove Patchsets with no comments
associated (e.g. PS1) , to ease the review process.

[emircan, 2016-11-09 22:14:38]

As mcasas@ pointed out, we sent a mail to the reviewer via "Publish+Mail
comments" when it is ready for another round. IF you reply to the comments
earlier, you can attach all your reponses via "Publish all my drafts" as well.

It is looking good except for the bot issues. Can you run "git rebase-update"
again, resolve the merge conflicts and upload a new patch?

https://codereview.chromium.org/2442193002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_controller.cc (right):

https://codereview.chromium.org/2442193002/diff/40001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_controller.cc:19: #include
"components/display_compositor/gl_helper.h"
We can remove this include now.

https://codereview.chromium.org/2442193002/diff/40001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_controller.cc:31: #include
"content/browser/compositor/image_transport_factory.h"
We can remove this include now.

https://codereview.chromium.org/2442193002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_controller.h (right):

https://codereview.chromium.org/2442193002/diff/40001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_controller.h:117: // If the
consumer provided resource utilization
nit: Can you fix the alignment here?
  // Return a buffer with id |buffer_id| previously given in
  // VideoCaptureControllerEventHandler::OnBufferReady. If the consumer
  // provided resource utilization feedback, this will be passed here (-1.0
  // indicates no feedback).

[emircan, 2016-11-09 22:14:40]

As mcasas@ pointed out, we sent a mail to the reviewer via "Publish+Mail
comments" when it is ready for another round. IF you reply to the comments
earlier, you can attach all your reponses via "Publish all my drafts" as well.

It is looking good except for the bot issues. Can you run "git rebase-update"
again, resolve the merge conflicts and upload a new patch?

[Yoric, 2016-11-10 13:11:56]

Patchset #1 (id:1) has been deleted

[emircan, 2016-12-16 21:42:38]

Friendly ping for yoric@. You are very close. Let me know if you have time to
finish this CL.

[Yoric, 2016-12-16 22:30:11]

On 2016/12/16 21:42:38, emircan wrote:
> Friendly ping for yoric@. You are very close. Let me know if you have time to
> finish this CL.

Unfortunately, I don't think I'll be able to finish this bug.

Rationale: after a simple `git pull`, rebuilding chokes to tears my (penultimate
generation MacBook Pro with 16Gb RAM) for ~12h. That's an actual wallclock time,
±20 minutes. It was strange the first time, annoying the second time, but the
4th and 5th were just too much for me, neither me nor my laptop have that kid of
free time.

So, thanks for the mentoring. I might show up again in a few years, once laptop
technology has improved. In the meantime, I wish you all the best.

[emircan, 2016-12-17 00:44:29]

Description was changed from

==========
Removing gpu::SyncToken usage from video capture pipeline, part 1.

The use of gpu::SyncToken has been added for the sake of capture into
textures, but is now useless. This patch removes all uses up to
`OnClientBufferFinished` (excluded).

BUG=653994
R=emircan@chromium.org
==========

to

==========
Removing gpu::SyncToken usage from video capture pipeline, part 1.

The use of gpu::SyncToken has been added for the sake of capture into
textures, but is now useless. This patch removes all uses up to
`OnClientBufferFinished` (excluded).

BUG=653994
R=emircan@chromium.org
CONTRIBUTORS=emircan@chromium.org
==========

[emircan, 2016-12-17 00:45:01]

Description was changed from

==========
Removing gpu::SyncToken usage from video capture pipeline, part 1.

The use of gpu::SyncToken has been added for the sake of capture into
textures, but is now useless. This patch removes all uses up to
`OnClientBufferFinished` (excluded).

BUG=653994
R=emircan@chromium.org
CONTRIBUTORS=emircan@chromium.org
==========

to

==========
Removing gpu::SyncToken usage from video capture pipeline, part 1.

The use of gpu::SyncToken has been added for the sake of capture into
textures, but is now useless. This patch removes all uses up to
`OnClientBufferFinished` (excluded).

BUG=653994
R=emircan@chromium.org
==========

[emircan, 2016-12-17 01:10:46]

On 2016/12/16 22:30:11, Yoric wrote:
> Unfortunately, I don't think I'll be able to finish this bug.
> 
> Rationale: after a simple `git pull`, rebuilding chokes to tears my
(penultimate
> generation MacBook Pro with 16Gb RAM) for ~12h. That's an actual wallclock
time,
> ±20 minutes. It was strange the first time, annoying the second time, but the
> 4th and 5th were just too much for me, neither me nor my laptop have that kid
of
> free time.
> 
> So, thanks for the mentoring. I might show up again in a few years, once
laptop
> technology has improved. In the meantime, I wish you all the best.
I completely understand your trouble with build :) Unfortuantely, these files
are very actively changed these days. Since you have done the work mostly, I
want to help just a bit more to complete it if you have a bit more time and
patience. If not, I still understand and thank you for your time.

Basically, you don't need to build it as I have rebased your patch for you.
Still, I cannot upload it to this CL as you are the owner. Follow the steps
below to apply it here:
git pull - to have latest version
git new-branch smt - start a clean branch
git cl patch 2583883003 - apply my rebased changes from
https://codereview.chromium.org/2583883003/ to your clean branch
git cl issue 2442193002 - make your branch point to this cl
git cl upload - upload the rebased patch here

Last things to do is to follow External Contributor Checklist
 here:
https://www.chromium.org/developers/contributing-code/external-contributor-ch....
That is to add your info to src/AUTHORS, upload a patch with it and sign CLA.