Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: content/browser/renderer_host/media/video_capture_controller.cc

Issue 2442193002: Removing gpu::SyncToken usage from video capture pipeline, part 1.
Patch Set: Removing gpu::SyncToken usage from video capture pipeline, part 1. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_controller.cc
diff --git a/content/browser/renderer_host/media/video_capture_controller.cc b/content/browser/renderer_host/media/video_capture_controller.cc
index 85f0a2948c7586ce94c82b43916f65668e3426d9..9a0b1c584c4625a51327708565d0a658591b9cfe 100644
--- a/content/browser/renderer_host/media/video_capture_controller.cc
+++ b/content/browser/renderer_host/media/video_capture_controller.cc
@@ -46,40 +46,6 @@ static const int kInfiniteRatio = 99999;
name, \
(height) ? ((width) * 100) / (height) : kInfiniteRatio);
-class SyncTokenClientImpl : public VideoFrame::SyncTokenClient {
- public:
- explicit SyncTokenClientImpl(display_compositor::GLHelper* gl_helper)
- : gl_helper_(gl_helper) {}
- ~SyncTokenClientImpl() override {}
- void GenerateSyncToken(gpu::SyncToken* sync_token) override {
- gl_helper_->GenerateSyncToken(sync_token);
- }
- void WaitSyncToken(const gpu::SyncToken& sync_token) override {
- gl_helper_->WaitSyncToken(sync_token);
- }
-
- private:
- display_compositor::GLHelper* gl_helper_;
-};
-
-void ReturnVideoFrame(const scoped_refptr<VideoFrame>& video_frame,
- const gpu::SyncToken& sync_token) {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
-#if defined(OS_ANDROID)
- NOTREACHED();
-#else
- display_compositor::GLHelper* gl_helper =
- ImageTransportFactory::GetInstance()->GetGLHelper();
- // UpdateReleaseSyncToken() creates a new sync_token using |gl_helper|, so
- // wait the given |sync_token| using |gl_helper|.
- if (gl_helper) {
- gl_helper->WaitSyncToken(sync_token);
- SyncTokenClientImpl client(gl_helper);
- video_frame->UpdateReleaseSyncToken(&client);
- }
-#endif
-}
-
std::unique_ptr<media::VideoCaptureJpegDecoder> CreateGpuJpegDecoder(
const media::VideoCaptureJpegDecoder::DecodeDoneCB& decode_done_cb) {
return base::MakeUnique<VideoCaptureGpuJpegDecoder>(decode_done_cb);
@@ -349,7 +315,6 @@ void VideoCaptureController::ReturnBuffer(
VideoCaptureControllerID id,
VideoCaptureControllerEventHandler* event_handler,
int buffer_id,
- const gpu::SyncToken& sync_token,
double consumer_resource_utilization) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
@@ -386,13 +351,6 @@ void VideoCaptureController::ReturnBuffer(
client->active_buffers.erase(iter);
buffer_pool_->RelinquishConsumerHold(buffer_id, 1);
-
-#if defined(OS_ANDROID)
- DCHECK(!sync_token.HasData());
-#endif
- if (sync_token.HasData())
- BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
- base::Bind(&ReturnVideoFrame, frame, sync_token));
}
const media::VideoCaptureFormat&

Powered by Google App Engine
This is Rietveld 408576698