Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: content/renderer/media/video_capture_impl.cc

Issue 2442193002: Removing gpu::SyncToken usage from video capture pipeline, part 1.
Patch Set: Removing gpu::SyncToken usage from video capture pipeline, part 1. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/video_capture_impl.cc
diff --git a/content/renderer/media/video_capture_impl.cc b/content/renderer/media/video_capture_impl.cc
index e7fd2b98f2ad596db86c55493adb4de9955c396d..2582859433c6f4843decad88d76422847e15abbe 100644
--- a/content/renderer/media/video_capture_impl.cc
+++ b/content/renderer/media/video_capture_impl.cc
@@ -227,8 +227,7 @@ void VideoCaptureImpl::OnBufferReceived(
if (state_ != VIDEO_CAPTURE_STATE_STARTED ||
pixel_format != media::PIXEL_FORMAT_I420 ||
storage_type != media::VideoFrame::STORAGE_SHMEM) {
- GetVideoCaptureHost()->ReleaseBuffer(device_id_, buffer_id,
- gpu::SyncToken(), -1.0);
+ GetVideoCaptureHost()->ReleaseBuffer(device_id_, buffer_id, -1.0);
return;
}
@@ -268,18 +267,16 @@ void VideoCaptureImpl::OnBufferReceived(
buffer->buffer_size(), buffer->buffer()->handle(),
0 /* shared_memory_offset */, timestamp);
if (!frame) {
- GetVideoCaptureHost()->ReleaseBuffer(device_id_, buffer_id,
- gpu::SyncToken(), -1.0);
+ GetVideoCaptureHost()->ReleaseBuffer(device_id_, buffer_id, -1.0);
return;
}
BufferFinishedCallback buffer_finished_callback = media::BindToCurrentLoop(
base::Bind(&VideoCaptureImpl::OnClientBufferFinished,
weak_factory_.GetWeakPtr(), buffer_id, buffer));
- std::unique_ptr<gpu::SyncToken> release_sync_token(new gpu::SyncToken);
frame->AddDestructionObserver(
base::Bind(&VideoCaptureImpl::DidFinishConsumingFrame, frame->metadata(),
- base::Passed(&release_sync_token), buffer_finished_callback));
+ buffer_finished_callback));
frame->metadata()->MergeInternalValuesFrom(metadata);
@@ -347,11 +344,10 @@ void VideoCaptureImpl::OnStateChanged(mojom::VideoCaptureState state) {
void VideoCaptureImpl::OnClientBufferFinished(
int buffer_id,
const scoped_refptr<ClientBuffer>& /* ignored_buffer */,
- const gpu::SyncToken& release_sync_token,
double consumer_resource_utilization) {
DCHECK(io_task_runner_->BelongsToCurrentThread());
GetVideoCaptureHost()->ReleaseBuffer(
- device_id_, buffer_id, release_sync_token, consumer_resource_utilization);
+ device_id_, buffer_id, consumer_resource_utilization);
}
void VideoCaptureImpl::StopDevice() {
@@ -442,7 +438,6 @@ mojom::VideoCaptureHost* VideoCaptureImpl::GetVideoCaptureHost() {
// static
void VideoCaptureImpl::DidFinishConsumingFrame(
const media::VideoFrameMetadata* metadata,
- std::unique_ptr<gpu::SyncToken> release_sync_token,
const BufferFinishedCallback& callback_to_io_thread) {
// Note: This function may be called on any thread by the VideoFrame
// destructor. |metadata| is still valid for read-access at this point.
@@ -451,8 +446,7 @@ void VideoCaptureImpl::DidFinishConsumingFrame(
&consumer_resource_utilization)) {
consumer_resource_utilization = -1.0;
}
-
- callback_to_io_thread.Run(*release_sync_token, consumer_resource_utilization);
+ callback_to_io_thread.Run(consumer_resource_utilization);
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698