Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2442083002: [DevTools] Merge Worker domain to Target, migrate clients. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Merge Worker domain to Target, migrate clients. BUG=648775 Committed: https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083 Cr-Commit-Position: refs/heads/master@{#427853}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : removed log->worker dependency #

Patch Set 4 : rebased all tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -503 lines) Patch
M content/browser/devtools/protocol/schema_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/dedicated-workers-list.html View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-agents-expected.txt View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-evaluate-in-worker-while-pause-in-page.html View 1 2 3 3 chunks +8 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker.html View 1 2 3 2 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html View 1 2 3 3 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setTimeout-sourceUrl-dedicated-worker-loop.html View 1 2 3 2 chunks +8 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-terminate-dedicated-worker-while-paused.html View 1 2 3 2 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/suspend-setTimeout-on-pause-in-dedicated-worker.html View 1 2 3 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html View 1 2 3 7 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/agents-enable-disable-expected.txt View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 5 chunks +51 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 2 3 6 chunks +6 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 1 2 3 4 chunks +24 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js View 1 2 3 1 chunk +0 lines, -244 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (16 generated)
dgozman
Could you please take a look?
4 years, 2 months ago (2016-10-21 18:59:09 UTC) #2
pfeldman
lgtm
4 years, 1 month ago (2016-10-24 19:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442083002/20001
4 years, 1 month ago (2016-10-25 23:02:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/259938)
4 years, 1 month ago (2016-10-26 00:00:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442083002/40001
4 years, 1 month ago (2016-10-26 00:08:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/322353)
4 years, 1 month ago (2016-10-26 02:13:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442083002/40001
4 years, 1 month ago (2016-10-26 02:18:51 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/322394)
4 years, 1 month ago (2016-10-26 02:24:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442083002/40001
4 years, 1 month ago (2016-10-26 03:33:16 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/319200)
4 years, 1 month ago (2016-10-26 05:11:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442083002/60001
4 years, 1 month ago (2016-10-26 19:28:30 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/223961) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-10-26 19:37:02 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442083002/60001
4 years, 1 month ago (2016-10-26 21:05:38 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-26 22:35:55 UTC) #29
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 22:40:15 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083
Cr-Commit-Position: refs/heads/master@{#427853}

Powered by Google App Engine
This is Rietveld 408576698