Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: content/browser/devtools/protocol/target_handler.cc

Issue 2442083002: [DevTools] Merge Worker domain to Target, migrate clients. (Closed)
Patch Set: rebased all tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/target_handler.cc
diff --git a/content/browser/devtools/protocol/target_handler.cc b/content/browser/devtools/protocol/target_handler.cc
index d03aa11e6788d56c8b4244fc0f3e547da62e0e41..254a4ac1f18d2bf98d56f8994177e9dab1d841a7 100644
--- a/content/browser/devtools/protocol/target_handler.cc
+++ b/content/browser/devtools/protocol/target_handler.cc
@@ -255,7 +255,7 @@ Response TargetHandler::SetAutoAttach(
bool auto_attach, bool wait_for_debugger_on_start) {
wait_for_debugger_on_start_ = wait_for_debugger_on_start;
if (auto_attach_ == auto_attach)
- return Response::OK();
+ return Response::FallThrough();
auto_attach_ = auto_attach;
if (auto_attach_) {
ServiceWorkerDevToolsManager::GetInstance()->AddObserver(this);
@@ -267,7 +267,7 @@ Response TargetHandler::SetAutoAttach(
ReattachTargetsOfType(empty, DevToolsAgentHost::kTypeFrame, false);
ReattachTargetsOfType(empty, DevToolsAgentHost::kTypeServiceWorker, false);
}
- return Response::OK();
+ return Response::FallThrough();
}
Response TargetHandler::SetAttachToFrames(bool value) {
@@ -313,7 +313,7 @@ Response TargetHandler::SendMessageToTarget(
const std::string& message) {
auto it = attached_hosts_.find(target_id);
if (it == attached_hosts_.end())
- return Response::InternalError("Not attached to the target");
+ return Response::FallThrough();
it->second->DispatchProtocolMessage(this, message);
return Response::OK();
}

Powered by Google App Engine
This is Rietveld 408576698