third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js - Issue 2442083002: [DevTools] Merge Worker domain to Target, migrate clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Issue 2442083002: [DevTools] Merge Worker domain to Target, migrate clients. (Closed)

Patch Set: rebased all tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/module.json ('k') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

index 7bdf2d2a397ba06405f11c58ea91624c5dd59c40..be3ad3e49e06c633332a1576dfda3d4bed05707e 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

@@ -267,7 +267,7 @@ WebInspector.TimelineController.prototype = {

var workerMetaEvents = metadataEvents.filter(event => event.name === metadataEventTypes.TracingSessionIdForWorker);

for (var metaEvent of workerMetaEvents) {

var workerId = metaEvent.args["data"]["workerId"];

- var workerTarget = this._target.workerManager ? this._target.workerManager.targetByWorkerId(workerId) : null;

+ var workerTarget = this._target.subTargetsManager ? this._target.subTargetsManager.targetForId(workerId) : null;

if (!workerTarget)

continue;

var cpuProfile = this._cpuProfiles.get(workerTarget.id());