Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4060)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

Issue 2441623002: Split MinidumpUploadService into core- and Chrome-implementation. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
index ef017e7f9da037f524bff7f56a48a6f764a2c908..716694e4c8372ca8fb851ba4bf53b8da7815be5f 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
@@ -19,6 +19,8 @@ import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.AdvancedMockContext;
import org.chromium.base.test.util.Feature;
+import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
+import org.chromium.components.minidump_uploader.util.MinidumpUploadDelegate;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
import org.chromium.net.NetworkChangeNotifier;
@@ -84,6 +86,31 @@ public class MinidumpUploadServiceTest extends CrashTestCase {
private void attachBaseContextLate(Context base) {
super.attachBaseContext(base);
}
+
+ @Override
+ protected MinidumpUploadDelegate getMinidumpUploadDelegate() {
+ return new MinidumpUploadDelegate() {
+ @Override
+ public void onSuccessfulUpload(Context context, String fileName) {}
+
+ @Override
+ public void onMaxedOutUploadFailures(Context context, String fileName) {}
+
+ @Override
+ public CrashReportingPermissionManager getCrashReportingPermissionManager() {
+ return new MinidumpUploadCallableTest.MockCrashReportingPermissionManager() {
+ {
+ mIsInSample = false;
+ mIsPermitted = false;
+ mIsUserPermitted = false;
+ mIsCommandLineDisabled = false;
+ mIsLimited = false;
+ mIsEnabledForTests = false;
+ }
+ };
+ }
+ };
+ }
}
@SmallTest

Powered by Google App Engine
This is Rietveld 408576698