Split MinidumpUploadService into core- and Chrome-implementation.

components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/MinidumpUploadDelegate.java

Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/MinidumpUploadDelegate.java
diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/MinidumpUploadDelegate.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/MinidumpUploadDelegate.java
new file mode 100644
index 0000000000000000000000000000000000000000..2195a8334ed800914deb0b4d5577df69c5136ab6
--- /dev/null
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/MinidumpUploadDelegate.java
@@ -0,0 +1,30 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.components.minidump_uploader.util;
+
+import android.content.Context;
+
+/**
+ * Interface giving clients of the Minidump uploader component the ability to control and log

[Ilya Sherman, 2016/10/21 00:27:27]

Optional nit: It's not clear to me that capitalizing "Minidump" is helpful --
I'd lowercase it throughout.

[gsennton, 2016/10/21 13:43:32]

Done.

+ * different stages of the uploading.
+ */
+public interface MinidumpUploadDelegate {
+    /**
+     * Called when a Minidump is uploaded successfully.
+     * @param fileName is the name of the Minidump file that was uploaded.

[Ilya Sherman, 2016/10/21 00:27:27]

nit: Please document the |context| param as well.

[gsennton, 2016/10/21 13:43:32]

Hah, it turns out the Context isn't even needed :) (See ChromePreferenceManager
- it was probably used to fetch shared preferences before the method
ContextUtils.getAppSharedPreferences() came along). It seems
ChromePreferenceManager is used in a lot of places though - maybe I should
remove that context in another CL? 
Generally people are not very good at documenting what a Context is for - an
Android Context is usually something you just pass around everywhere because it
is used in ctors of many Android objects and it holds pointers to useful stuff.

[Ilya Sherman, 2016/10/21 21:47:51]

Yep, a separate CL to remove it would be great -- thanks!

[gsennton, 2016/10/25 13:13:53]

Filed crbug.com/659038 so I don't forget this.

+     */
+    void onSuccessfulUpload(Context context, String fileName);

[Ilya Sherman, 2016/10/21 00:27:27]

nit: Would it make sense to pass a crash type rather than a filename?  (Ditto
below.)

[gsennton, 2016/10/21 13:43:32]

Definitely :), done.

+
+    /**
+     * Called when we fail to upload a Minidump too many times.
+     * @param fileName is the name of the Minidump file that failed to be uploaded.
+     */
+    void onMaxedOutUploadFailures(Context context, String fileName);
+
+    /**
+     * @return A permission manager determining whether a Minidump can be uploaded at certain times.
+     */
+    CrashReportingPermissionManager getCrashReportingPermissionManager();
+}