chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java - Issue 2441623002: Split MinidumpUploadService into core- and Chrome-implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java

Issue 2441623002: Split MinidumpUploadService into core- and Chrome-implementation. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java ('K') | « chrome/android/java_sources.gni ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java » ('j') | components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/MinidumpUploadDelegate.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java

index 8f4f7ccab606d98e89cde1764f3c5992bc16a1ba..5ff8364efe974622c9fbff06273599502df57c63 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java

@@ -111,8 +111,7 @@ public class MinidumpUploadCallableTest extends CrashTestCase {

}

- private static class MockCrashReportingPermissionManager

- implements CrashReportingPermissionManager {

+ static class MockCrashReportingPermissionManager implements CrashReportingPermissionManager {

protected boolean mIsInSample;

protected boolean mIsPermitted;

protected boolean mIsUserPermitted;