[full-codegen] Eliminate unnecessary hole checks for stores

[full-codegen] Eliminate unnecessary hole checks for stores

Loads already used source position elimination to avoid unnecessary hole checks,
but for reasons unknown stores did not. This CL corrects that, making full-codegen's
hole elimination equivalent to ignition's.

Also introduced a HoleCheckMode enum class to avoid more bool flags and updated
VariableProxy and BytecodeGenerator appropriately.

Committed: https://crrev.com/231c8ac0a78dd3d28f5398452c139062430ff008
Cr-Commit-Position: refs/heads/master@{#40522}

[adamk, 2016-10-21 11:21:40]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 11:21:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 11:24:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 11:24:34]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[adamk, 2016-10-21 13:23:13]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 13:23:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-21 13:24:33]

Description was changed from

==========
[full-codegen] Eliminate unnecessary hole checks for stores
==========

to

==========
[full-codegen] Eliminate unnecessary hole checks for stores

Loads already used source position elimination to avoid unnecessary hole checks,
but for reasons unknown stores did not. This CL corrects that, making
full-codegen's
hole elimination equivalent to ignition's.

Also introduced a HoleCheckMode enum class to avoid more bool flags and updated
VariableProxy and BytecodeGenerator appropriately.
==========

[adamk, 2016-10-21 13:25:23]

adamk@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[adamk, 2016-10-21 13:25:24]

Here's the hole check elimination feature I was talking about this morning
(along with an enum class to get rid of those bools). PTAL and I'll add ports if
the approach looks Ok to you.

[commit-bot: I haz the power, 2016-10-21 13:28:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 13:28:35]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Michael Starzinger, 2016-10-21 13:41:52]

LGTM (once ports are added). I like it. Thanks!

[adamk, 2016-10-21 14:06:23]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 14:06:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 14:18:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 14:18:25]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[adamk, 2016-10-21 16:44:15]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[adamk, 2016-10-21 16:44:24]

Ported!

[commit-bot: I haz the power, 2016-10-21 16:44:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 16:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 16:48:16]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/16663)

[adamk, 2016-10-21 21:05:48]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 21:05:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 21:08:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 21:08:37]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/16585)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[adamk, 2016-10-24 07:39:12]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-10-24 07:39:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2441543005/#ps80001
(title: "Merge and fix modules")

[commit-bot: I haz the power, 2016-10-24 07:39:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 08:08:49]

Description was changed from

==========
[full-codegen] Eliminate unnecessary hole checks for stores

Loads already used source position elimination to avoid unnecessary hole checks,
but for reasons unknown stores did not. This CL corrects that, making
full-codegen's
hole elimination equivalent to ignition's.

Also introduced a HoleCheckMode enum class to avoid more bool flags and updated
VariableProxy and BytecodeGenerator appropriately.
==========

to

==========
[full-codegen] Eliminate unnecessary hole checks for stores

Loads already used source position elimination to avoid unnecessary hole checks,
but for reasons unknown stores did not. This CL corrects that, making
full-codegen's
hole elimination equivalent to ignition's.

Also introduced a HoleCheckMode enum class to avoid more bool flags and updated
VariableProxy and BytecodeGenerator appropriately.
==========

[commit-bot: I haz the power, 2016-10-24 08:08:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-17 22:10:36]

Description was changed from

==========
[full-codegen] Eliminate unnecessary hole checks for stores

Loads already used source position elimination to avoid unnecessary hole checks,
but for reasons unknown stores did not. This CL corrects that, making
full-codegen's
hole elimination equivalent to ignition's.

Also introduced a HoleCheckMode enum class to avoid more bool flags and updated
VariableProxy and BytecodeGenerator appropriately.
==========

to

==========
[full-codegen] Eliminate unnecessary hole checks for stores

Loads already used source position elimination to avoid unnecessary hole checks,
but for reasons unknown stores did not. This CL corrects that, making
full-codegen's
hole elimination equivalent to ignition's.

Also introduced a HoleCheckMode enum class to avoid more bool flags and updated
VariableProxy and BytecodeGenerator appropriately.

Committed: https://crrev.com/231c8ac0a78dd3d28f5398452c139062430ff008
Cr-Commit-Position: refs/heads/master@{#40522}
==========

[commit-bot: I haz the power, 2016-11-17 22:10:37]

Patchset 5 (id:??) landed as
https://crrev.com/231c8ac0a78dd3d28f5398452c139062430ff008
Cr-Commit-Position: refs/heads/master@{#40522}