Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: src/ast/ast.h

Issue 2441543005: [full-codegen] Eliminate unnecessary hole checks for stores (Closed)
Patch Set: Merge and fix modules Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/ast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index 75c548806b792c1ee5e3f55811bd2ea01f663190..28004058f231dc30c93a7f26e9d1a2cf78dac17a 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -1671,11 +1671,12 @@ class VariableProxy final : public Expression {
bit_field_ = IsNewTargetField::update(bit_field_, true);
}
- bool needs_hole_check() const {
- return NeedsHoleCheckField::decode(bit_field_);
+ HoleCheckMode hole_check_mode() const {
+ return HoleCheckModeField::decode(bit_field_);
}
void set_needs_hole_check() {
- bit_field_ = NeedsHoleCheckField::update(bit_field_, true);
+ bit_field_ =
+ HoleCheckModeField::update(bit_field_, HoleCheckMode::kRequired);
}
int end_position() const { return end_position_; }
@@ -1713,8 +1714,8 @@ class VariableProxy final : public Expression {
class IsAssignedField : public BitField<bool, IsThisField::kNext, 1> {};
class IsResolvedField : public BitField<bool, IsAssignedField::kNext, 1> {};
class IsNewTargetField : public BitField<bool, IsResolvedField::kNext, 1> {};
- class NeedsHoleCheckField
- : public BitField<bool, IsNewTargetField::kNext, 1> {};
+ class HoleCheckModeField
+ : public BitField<HoleCheckMode, IsNewTargetField::kNext, 1> {};
// Position is stored in the AstNode superclass, but VariableProxy needs to
// know its end position too (for error messages). It cannot be inferred from
« no previous file with comments | « no previous file | src/ast/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698