Make bisect not break when buildbucket.get fails.

Make bisect not break when buildbucket.get fails.

There's fixes for both staging and production branches, but only staging
has full test coverage (due to the refactor, which allows this).

R=prasadv@chromium.org,dtu@chromium.org
BUG=629896
Committed: https://chromium.googlesource.com/chromium/tools/build/+/8b65c34f07490a0ddebdf96d0e755821c876847b

[prasadv1, 2016-10-21 21:37:16]

prasadv@google.com changed reviewers:
+ prasadv@google.com

[prasadv1, 2016-10-21 21:37:17]

https://codereview.chromium.org/2441143002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/auto_bisect/revision_state.py (right):

https://codereview.chromium.org/2441143002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/auto_bisect/revision_state.py:308: # If the check
fails, we cannot assume that the build is failed.
What should happen when buildbucket.get() fails and also build is failed?

[RobertoCN, 2016-10-21 21:58:12]

On 2016/10/21 21:37:17, prasadv1 wrote:
>
https://codereview.chromium.org/2441143002/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/auto_bisect/revision_state.py (right):
> 
>
https://codereview.chromium.org/2441143002/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/auto_bisect/revision_state.py:308: # If the check
> fails, we cannot assume that the build is failed.
> What should happen when buildbucket.get() fails and also build is failed?

We'll keep checking both GS:// and buildbucket. If the buildbucket.get error is
transient, then it should continue normally. Otherwise it will time out
eventually.

[prasadv1, 2016-10-21 22:01:24]

lgtm

[RobertoCN, 2016-10-21 22:09:12]

The CQ bit was checked by robertocn@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 22:21:12]

Description was changed from

==========
Make bisect not break when buildbucket.get fails.

There's fixes for both staging and production branches, but only staging
has full test coverage (due to the refactor, which allows this).

R=prasadv@chromium.org,dtu@chromium.org
BUG=629896
==========

to

==========
Make bisect not break when buildbucket.get fails.

There's fixes for both staging and production branches, but only staging
has full test coverage (due to the refactor, which allows this).

R=prasadv@chromium.org,dtu@chromium.org
BUG=629896

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/8b65c34f07490a0ddebd...
==========

[commit-bot: I haz the power, 2016-10-21 22:21:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/8b65c34f07490a0ddebd...