Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py

Issue 2441143002: Make bisect not break when buildbucket.get fails. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py b/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
index 39b6640dfc289dac29cac5d52a5b5f7c9182798d..d06a8ac7880345e86c325e548dac24b26d42965d 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
@@ -281,11 +281,15 @@ class RevisionState(object):
def _is_build_failed(self):
api = self.bisector.api
- result = api.m.buildbucket.get_build(
- self.build_id,
- api.m.service_account.get_json_path(api.SERVICE_ACCOUNT),
- step_test_data=lambda: api.test_api.buildbot_job_status_mock(
- api._test_data.get('build_status', {}).get(self.commit_hash, [])))
+ try:
+ result = api.m.buildbucket.get_build(
+ self.build_id,
+ api.m.service_account.get_json_path(api.SERVICE_ACCOUNT),
+ step_test_data=lambda: api.test_api.buildbot_job_status_mock(
+ api._test_data.get('build_status', {}).get(self.commit_hash, [])))
+ except api.m.step.StepFailure:
+ # If the check fails, we cannot assume that the build is failed.
+ return False
return (result.stdout['build']['status'] == 'COMPLETED' and
result.stdout['build'].get('result') != 'SUCCESS')

Powered by Google App Engine
This is Rietveld 408576698