Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/example.py

Issue 2441143002: Make bisect not break when buildbucket.get fails. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect_staging/example.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/example.py b/scripts/slave/recipe_modules/auto_bisect_staging/example.py
index 3d16f24ca4cecd0d3535ec6c7c05efa5e0da98b6..0e7ca1627be17a70d15738b1cb8019d93ebd18ce 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/example.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/example.py
@@ -718,3 +718,45 @@ def GenTests(api):
'result': 'FAILED'}}],
},
]))
+ yield (
+ api.test('failed_buildbucket_get')
+ + api.properties(
+ mastername='tryserver.chromium.perf',
+ buildername='linux_perf_bisect',
+ slavename='dummyslave',
+ buildnumber=571,
+ bisect_config={
+ 'test_type': 'perf',
+ 'command':
+ ('src/tools/perf/run_benchmark -v --browser=release '
+ '--output-format=valueset smoothness.tough_scrolling_cases'),
+ 'good_revision': '314015',
+ 'bad_revision': '314016',
+ 'metric': 'mean_input_event_latency/mean_input_event_latency',
+ 'bug_id': '-1',
+ 'gs_bucket': 'chrome-perf',
+ 'dummy_builds': 'True',
+ 'dummy_tests': 'True',
+ 'dummy_job_names': 'True',
+ 'bypass_stats_check': 'True',
+ 'skip_gclient_ops': 'True',
+ 'recipe_tester_name': 'linux_perf_tester'
+ })
+ + api.auto_bisect_staging([
+ {
+ 'hash': 'a6298e4afedbf2cd461755ea6f45b0ad64222222',
+ 'commit_pos': '314015',
+ 'parsed_values': [19, 20, 23, 1],
+ 'gsutil_exists': 2 * [False],
+ 'test_results': 5 * [{'stdout': 'benchmark text', 'retcode': 0}],
+ 'build_status': [{'build': {'status': 'SCHEDULED'}},
+ {'build': {'status': 'COMPLETED',
+ 'result': 'SUCCESS'}}],
+ },
+ {
+ 'hash': 'dcdcdc0ff1122212323134879ddceeb1240b0988',
+ 'commit_pos': '314016',
+ 'gsutil_exists': 10 * [False],
+ 'build_status': ['ERROR'],
+ },
+ ]))

Powered by Google App Engine
This is Rietveld 408576698