fix #27642, static members should now work

fix #27642, static members should now work

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/982f9f46edec2a69b3c06fda4079401f329945cc

[Jennifer Messerly, 2016-10-21 00:05:40]

Description was changed from

==========
wip

BUG=
==========

to

==========
fix #27642, static members should now work
==========

[Jennifer Messerly, 2016-10-21 00:05:40]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-10-21 00:18:51]

I updated the test expectations as well. A lot of tests are passing now.

[vsm, 2016-10-21 02:07:16]

lgtm

https://codereview.chromium.org/2440863002/diff/20001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2440863002/diff/20001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:4665: target.staticElement
is TypeDefiningElement;
Hmm, do we need target is SimpleIdentifier?

Might have:

foo.A.x;

where foo is a library prefix.

[Jennifer Messerly, 2016-10-21 17:48:07]

thanks

https://codereview.chromium.org/2440863002/diff/20001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2440863002/diff/20001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:4665: target.staticElement
is TypeDefiningElement;
On 2016/10/21 02:07:16, vsm wrote:
> Hmm, do we need target is SimpleIdentifier?

yes, we need something. You can't get a staticElement from an Expression

> Might have:
> 
> foo.A.x;
> 
> where foo is a library prefix.

yes, I believe this is handled by _emitAccess and is why tests passed, but I
will double check. If not, we can also add a "target is PrefixedIdentifier"
branch.

[Jennifer Messerly, 2016-10-21 17:49:54]

BTW, I'll try Paul's fix (https://codereview.chromium.org/2439023002) and see if
I can drop the code_generator changes :)

[Jennifer Messerly, 2016-10-21 18:25:58]

Description was changed from

==========
fix #27642, static members should now work
==========

to

==========
fix #27642, static members should now work

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/982f9f46edec2a69b3c06fda4079...
==========

[Jennifer Messerly, 2016-10-21 18:25:59]

Committed patchset #3 (id:40001) manually as
982f9f46edec2a69b3c06fda4079401f329945cc (presubmit successful).

[Jennifer Messerly, 2016-10-21 18:25:59]

Landing as only the test status updates thanks to Paul! :)